Ble remove user facing abstraction #13475

pan- · 2020-08-21T21:45:32Z

Summary of changes

Completion of BLE streamlining:

Makes public API relevant and not just fake for doxygen
Reorganise public headers:
- ble/common: For code common in gatt, gap and drivers
- ble/driver: HCI driver interface declaration
- ble/gap: declarations related to gap
- ble/gatt: declarations related to gatt
- ble/service: ble services
- ble/compatibility: Legacy path for backward compatibility
reorganise sources and move private headers with them:
- source: Entry point to private implementation of Gap, GattClient, GattServer and SecurityManager
- source/generic: Generic implementation for Gap, GattClient, GattServer and SecurityManager
- source/pal: PAL declaration used by the generic implementation
- source/gatt: Definition of public gatt related classes
- source/gap: Definition of public gap related classes
- source/cordio: Implementation of the pal and assembly of the various elements in BleInstanceBaseImpl.
move cordio stack out of TARGET_CORDIO. It is located in ble/libraries
Expose HCI driver at the root of BLE API.

Impact of changes

Migration actions required

Documentation

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@paul-szczepanek-arm @LDong-Arm

mergify · 2020-08-21T21:46:11Z

This PR cannot be merged due to conflicts. Please rebase to resolve them.

ciarmcom · 2020-08-21T22:00:35Z

@pan-, thank you for your changes.
@LDong-Arm @paul-szczepanek-arm @ARMmbed/mbed-os-maintainers please review.

- Missing default assignment operator - Field order in construction list - Typo - Unused header

Move private headers GattServerEvents.h, GapEvents,h and GapType.h in relevant part of the source tree.

pan- · 2020-09-04T14:32:32Z

@0xc0170 Can we get CI for this PR ?

0xc0170 · 2020-09-07T08:19:05Z

CI started

mbed-ci · 2020-09-07T08:50:05Z

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM	❌
jenkins-ci/mbed-os-ci_build-ARM	❌

pan- · 2020-09-07T13:47:47Z

@0xc0170 Some issues were present with Cypress drivers due to the removal of mbed.h and a missing implementation from ARMC6. Would it be possible to launch a new run once the sanity check has proceeded ?

0xc0170 · 2020-09-08T07:24:55Z

CI restarted

mbed-ci · 2020-09-08T08:10:08Z

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-ARM	✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest	✔️

pan- · 2020-09-09T08:23:24Z

@0xc0170 Is there anything the pan team can do to speed up the integration process ?

0xc0170

We might need your help to get this in also to the feature-cmake branch.

pan- added the do not merge label Aug 21, 2020

mergify bot added the needs: work label Aug 21, 2020

ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Aug 21, 2020

ciarmcom requested review from LDong-Arm, paul-szczepanek-arm and a team August 21, 2020 22:00

ciarmcom added the needs: review label Aug 21, 2020

pan- added 21 commits August 25, 2020 11:11

PIMPL for ble::Gap

909676d

ble: GattClient PIMPL

e3cf59e

BLE: SecurityManager PIMPL

2b48d48

BLE: GattServer PIMPL

cf3ede0

BLE: Move constructor from transport to private section

0929478

BLE: Bind interface to private implementation.

c773870

BLE: Warning cleanup

41c8c22

- Missing default assignment operator - Field order in construction list - Typo - Unused header

BLE: Move generic implementation and headers into source/generic

381700a

BLE: Move SecurityDB related files into generic sources

c2a09ab

BLE: Move BleInstanceBase.h into source.

a453259

BLE: move PAL headers into source/pal

e11bfb6

BLE: Move gap public header at the root.

d3427ca

BLE: Move common publi headers into ble/common

27cb038

BLE: Move GATT public header into ble/gatt

13c3587

Move private headers GattServerEvents.h, GapEvents,h and GapType.h in relevant part of the source tree.

BLE: Add compatibility path for headers.

63ac8fa

BLE: Fix address copy in Nordic HCI driver.

94cf390

BLE: Move cordio_stack out of TARGET_CORDIO

134cb88

BLE: Move generic lib file into source/generic .

cc78150

BLE: Move Cordio implementation in source/impl

dd54bae

BLE: Expose HCI driver in public API.

0baa92d

BLE: Clang tidy on public headers.

7cbc0e3

pan- requested a review from paul-szczepanek-arm September 4, 2020 14:32

paul-szczepanek-arm approved these changes Sep 4, 2020

View reviewed changes

BLE: fix code indentation

4bd7f8c

mergify bot added needs: work and removed needs: review labels Sep 7, 2020

pan- mentioned this pull request Sep 7, 2020

Host privacy implementation #13560

Merged

8 tasks

pan- added 2 commits September 7, 2020 14:32

BLE: reintroduce default implementation GattClient::discoverServices.

904b7f5

Cypress BLE driver: Fix removal of mbed.h

ea47ee0

pan- requested a review from paul-szczepanek-arm September 7, 2020 15:50

pan- added needs: review and removed needs: work labels Sep 7, 2020

paul-szczepanek-arm approved these changes Sep 8, 2020

View reviewed changes

This was referenced Sep 8, 2020

Fix enabling/disabling BLE-Features #13545

Merged

fix namespaces for MBED_NO_GLOBAL_USING_DIRECTIVE feature #13568

Closed

0xc0170 approved these changes Sep 9, 2020

View reviewed changes

0xc0170 added ready for merge and removed needs: review labels Sep 9, 2020

0xc0170 merged commit c99ff74 into ARMmbed:master Sep 9, 2020

mergify bot removed the ready for merge label Sep 9, 2020

mbedmain added release-version: 6.3.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 14, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Ble remove user facing abstraction #13475

Ble remove user facing abstraction #13475

pan- commented Aug 21, 2020 •

edited

Loading

mergify bot commented Aug 21, 2020

ciarmcom commented Aug 21, 2020

pan- commented Sep 4, 2020

0xc0170 commented Sep 7, 2020

mbed-ci commented Sep 7, 2020

pan- commented Sep 7, 2020

0xc0170 commented Sep 8, 2020

mbed-ci commented Sep 8, 2020

pan- commented Sep 9, 2020

0xc0170 left a comment

Ble remove user facing abstraction #13475

Ble remove user facing abstraction #13475

Conversation

pan- commented Aug 21, 2020 • edited Loading

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

mergify bot commented Aug 21, 2020

ciarmcom commented Aug 21, 2020

pan- commented Sep 4, 2020

0xc0170 commented Sep 7, 2020

mbed-ci commented Sep 7, 2020

Jenkins CI Test : ❌ FAILED

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

pan- commented Sep 7, 2020

0xc0170 commented Sep 8, 2020

mbed-ci commented Sep 8, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

pan- commented Sep 9, 2020

0xc0170 left a comment

Choose a reason for hiding this comment

pan- commented Aug 21, 2020 •

edited

Loading