Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STM32: Fix system clock setup for XTAL and/or internal source on STM32H743 #13640

Merged
merged 2 commits into from
Sep 23, 2020
Merged

STM32: Fix system clock setup for XTAL and/or internal source on STM32H743 #13640

merged 2 commits into from
Sep 23, 2020

Conversation

isaev-d
Copy link
Contributor

@isaev-d isaev-d commented Sep 20, 2020

Summary of changes

Fix #13591
PLL configuration for system clock was wrong for cases of internal clock source or external resonator.

Impact of changes

Applies to nucleo H743 board. Another members of series also could be effected, but that wasn't tested.

Migration actions required

Documentation

To test XTAL create file mbed_app.json with following detectives:

{ "target_overrides": { "NUCLEO_H743ZI2": { "target.clock_source": "USE_PLL_HSE_XTAL", "target.hse_value": "25000000" } } }
To use internal clock source:
{ "target_overrides": { "NUCLEO_H743ZI2": { "target.clock_source": "USE_PLL_HSI" } } }

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[X] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jeromecoutant

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Sep 20, 2020
@ciarmcom ciarmcom requested review from jeromecoutant and a team September 20, 2020 14:30
@ciarmcom
Copy link
Member

@isaev-d, thank you for your changes.
@jeromecoutant @ARMmbed/mbed-os-maintainers please review.

jeromecoutant
jeromecoutant reviewed Sep 21, 2020
View reviewed changes
Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will approve, just remove the unexpected space
and correct the PR header into H743 :-)
Thx!

targets/TARGET_STM/TARGET_STM32H7/TARGET_STM32H743xI/TARGET_NUCLEO_H743ZI2/system_clock.c Outdated
@@ -72,7 +72,7 @@ void SetSysClock(void)
#if ((CLOCK_SOURCE) & USE_PLL_HSE_XTAL)
/* 2- If fail try to start with HSE and external xtal */
if (SetSysClock_PLL_HSE(0) == 0)
#endif
#endif
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor comment, remove space

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, space removed = )
Also I changed error message to compile time check. Check it please, @jeromecoutant

@0xc0170 0xc0170 changed the title Fixed system clock setup for XTAL and/or internal source on stm32f743… STM32: Fix system clock setup for XTAL and/or internal source on stm32f743 Sep 21, 2020
0xc0170
0xc0170 previously requested changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One styling request above to resolve

@jeromecoutant jeromecoutant mentioned this pull request Sep 21, 2020
Merged
@mergify mergify bot dismissed 0xc0170’s stale review September 21, 2020 17:32

Pull request has been modified.

jeromecoutant
jeromecoutant approved these changes Sep 22, 2020
View reviewed changes
Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a comment on the PR header:
internal source on stm32f743
=> internal source on STM32H743 :-)

@isaev-d isaev-d changed the title STM32: Fix system clock setup for XTAL and/or internal source on stm32f743 STM32: Fix system clock setup for XTAL and/or internal source on stm32h743 Sep 22, 2020
@isaev-d isaev-d changed the title STM32: Fix system clock setup for XTAL and/or internal source on stm32h743 STM32: Fix system clock setup for XTAL and/or internal source on STM32H743 Sep 22, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Sep 23, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 23, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@0xc0170 0xc0170 merged commit 60cbab3 into ARMmbed:master Sep 23, 2020
@mergify mergify bot removed the ready for merge label Sep 23, 2020
@isaev-d isaev-d deleted the fix-pll-stm32h743 branch September 23, 2020 10:28
@mbedmain mbedmain added release-version: 6.4.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch labels Oct 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@jeromecoutant jeromecoutant jeromecoutant approved these changes

Assignees
No one assigned
Labels
release-version: 6.4.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wrong PLL configuration on STM32H743
6 participants
@isaev-d @ciarmcom @0xc0170 @mbed-ci @jeromecoutant @mbedmain