Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix STM32H747 Arduino pinout #13652

Merged
merged 1 commit into from
Oct 22, 2020
Merged

Fix STM32H747 Arduino pinout #13652

merged 1 commit into from
Oct 22, 2020

Conversation

felipeLeast
Copy link

Summary of changes

Changing Pin Names for Arduino header on STM32H747

Impact of changes

Migration actions required

Documentation

No documentation required

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jeromecoutant

@ciarmcom ciarmcom requested review from jeromecoutant and a team September 21, 2020 16:30
@ciarmcom
Copy link
Member

@felipeLeast, thank you for your changes.
@jeromecoutant @ARMmbed/mbed-os-maintainers please review.

0xc0170
0xc0170 previously approved these changes Sep 22, 2020
View reviewed changes
@mergify mergify bot added needs: CI and removed needs: review labels Sep 22, 2020
jeromecoutant
jeromecoutant suggested changes Sep 22, 2020
View reviewed changes
Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch, User Manual seems wrong :-(
I checked schematics, seems better.

targets/TARGET_STM/TARGET_STM32H7/TARGET_STM32H747xI/TARGET_DISCO_H747I/PinNames.h Outdated
@@ -310,7 +310,7 @@ typedef enum {
ADC_VBAT = 0xF2,

// Arduino connector namings
A0 = PF_7,
A0 = PF_4,
Copy link
Collaborator

@jeromecoutant jeromecoutant Sep 22, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PA_4

@jeromecoutant
Copy link
Collaborator

Good catch, User Manual seems wrong :-(
I checked schematics, seems better.

In fact, I knew the issue...
Already corrected in master branch in #13073

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 30, 2020

@felipeLeast Can you fix the comment above?

@mbed-ci
Copy link

mbed-ci commented Sep 30, 2020

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 1
Build artifacts

@felipeLeast
Copy link
Author

@felipeLeast Can you fix the comment above?

done

@mergify mergify bot dismissed 0xc0170’s stale review September 30, 2020 15:44

Pull request has been modified.

andypowers
andypowers approved these changes Oct 12, 2020
View reviewed changes
Copy link
Collaborator

@andypowers andypowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@mergify mergify bot added needs: CI and removed needs: work labels Oct 12, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 13, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Oct 13, 2020

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 1
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest-lts

@mbed-ci
Copy link

mbed-ci commented Oct 14, 2020

Test run: FAILED

Summary: 1 of 10 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_cloud-client-pytest-lts

@mergify mergify bot added needs: work and removed needs: CI labels Oct 14, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Oct 21, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Oct 21, 2020

Test run: SUCCESS

Summary: 10 of 10 test jobs passed
Build number : 3
Build artifacts

@0xc0170 0xc0170 merged commit 0e00ff7 into ARMmbed:mbed-os-5.15 Oct 22, 2020
@mergify mergify bot removed the ready for merge label Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromecoutant jeromecoutant jeromecoutant approved these changes

@andypowers andypowers andypowers approved these changes

@0xc0170 0xc0170 0xc0170 left review comments

Assignees
No one assigned
Labels
release-version: 5.15.6
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@felipeLeast @ciarmcom @jeromecoutant @0xc0170 @mbed-ci @andypowers