COMPONENT_FPGA_CI_TEST_SHIELD: better debug print #13768
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
|
@jeromecoutant, thank you for your changes. |
0xc0170
reviewed
Nov 3, 2020
| @@ -215,9 +217,11 @@ template<typename PortType, typename FunctionType, FunctionType f> | |||
| void test_peripheral(PortType &port) | |||
| { | |||
| if (port.empty()) { | |||
| utest_printf("%d - Could not find pins to test peripheral\n", port.peripheral); | |||
| if (port.peripheral != NC) { | |||
There was a problem hiding this comment.
shouldn't port.empty() already do the trick do we need additional if here? If yes, lets move it to line 219 (condtion && condition)
There was a problem hiding this comment.
No, as the following else is valid only for the first condition
Yes, these prints are the one I (we...) need to work effectively with FPGA |
0xc0170
approved these changes
Nov 12, 2020
|
CI started |
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
CI started |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
mbedmain
removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Here is few updates in COMPONENT_FPGA_CI_TEST_SHIELD print console,
that helps user to debug.
Thx
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
FPGA tests verified with DISCO L475
Reviewers