Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BLE: Fix Security Manager key generation #14125

Merged
merged 2 commits into from
Jan 11, 2021

Conversation

pan-
Copy link
Member

@pan- pan- commented Jan 7, 2021

Summary of changes

Fix bug in key generation of the Bluetooth Security manager:

  • Only 8 bytes of random data where fetched at the time
  • The CSRK was not regenerated if invalid (all zeroes).

Impact of changes

Migration actions required

Documentation

None. This is an internal change.


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tests / results supplied as part of this PR

Reviewers

@paul-szczepanek-arm @noonfom


Ensure the more than 8 random bytes are fetched from the stack.
@pan- pan- changed the title Fix sm key generation BLE: Fix Security Manager key generation Jan 7, 2021
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Jan 7, 2021
@ciarmcom ciarmcom requested review from a team January 7, 2021 13:00
@ciarmcom
Copy link
Member

ciarmcom commented Jan 7, 2021

@pan-, thank you for your changes.
@ARMmbed/mbed-os-connectivity @ARMmbed/mbed-os-maintainers please review.

@pan- pan- mentioned this pull request Jan 8, 2021
@mergify mergify bot added needs: CI and removed needs: review labels Jan 11, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 11, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 11, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️

@0xc0170 0xc0170 merged commit 53776fe into ARMmbed:master Jan 11, 2021
@mergify mergify bot removed the ready for merge label Jan 11, 2021
@mbedmain mbedmain added release-version: 6.7.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants