CMake: greentea: Remove dependency on global MBED_PATH #14876
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbed_greentea::mbed_greentea_add_test was calling the deprecated `mbed_configure_app_target` function, which is currently a no-op.
0xc0170
previously approved these changes
Jul 6, 2021
|
CI started |
Patater
reviewed
Jul 6, 2021
The mbed_greentea_add_test macro required a greentea test to set an MBED_PATH variable to the path of the mbed-os root directory, which it attempts to add as a 'subdirectory' of the test project. We can instead use CMake's built in CMAKE_CURRENT_LIST_DIR variable to deduce the path to mbed-os relative to the current list file directory, removing the need for greentea tests to set MBED_PATH.
rwalton-arm
force-pushed
the
mbed_path_greentea
branch
from
56667ca
to
dfb4e08
Compare
ciarmcom
added
the
release-type: patch
|
@rwalton-arm, thank you for your changes. |
Patater
approved these changes
Jul 6, 2021
|
CI restarted |
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
|
^^ Aborted (new job was created) |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
LDong-Arm
suggested changes
Jul 6, 2021
LDong-Arm
approved these changes
Jul 6, 2021
mbedmain
added
release-version: 6.13.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
The mbed_greentea_add_test macro required a greentea test to set an
MBED_PATH variable to the path of the mbed-os root directory, which it
attempts to add as a 'subdirectory' of the test project. We can instead
use CMake's built in CMAKE_CURRENT_LIST_DIR variable to deduce the path
to mbed-os relative to the current list file directory, removing the
need for greentea tests to set MBED_PATH.
Greentea tests themselves still generally use MBED_PATH as a local variable
to allow them to import the mbed_greentea module. This will be easily fixed
when we structure the tests so mbed-os is the top level project, the same way
we structured the unit tests. When the architecture is correct, we can add the
mbed_greentea module to CMAKE_MODULE_PATH in mbed-os/CMakeLists.txt.
Removing the need to provide an absolute path to the module in every CMake
file which includes it.
Impact of changes
N/A
Migration actions required
N/A
Documentation
None
Pull request type
Test results
Reviewers