Passing toolchain path info to subprocesses #3274
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
theotherjimmy
approved these changes
Nov 17, 2016
| @@ -2122,7 +2128,6 @@ def build_tests(tests, base_source_paths, build_path, target, toolchain_name, | |||
|
|
|||
| Returns a tuple of the build result (True or False) followed by the test | |||
| build data structure""" | |||
|
|
|||
There was a problem hiding this comment.
I think I just missed that change when I had some debug prints. If you feel REALLLY strongly about it I'll remove it, otherwise I might just let it simmer :)
Since the toolchain path info lives as a global variable, its not propigating to the subprocesses that are created to compile the tests in parallel. This change manually passes these global variables and then reassigns them.
bridadan
force-pushed
the
fix-path-detection-test-building
branch
from
05140dc
to
57e693d
Compare
|
Fixed the style :) Shouldn't be necessary to re run tests, just added a blank line again. |
|
@0xc0170 Can you take a look please? Should be ready to go if you're happy. |
|
@0xc0170 Bumpity bump :) |
0xc0170
added
release-version: 5.2.4
ready for merge
release-version: 5.3.1
and removed
needs: review
release-version: 5.2.4
ready for merge
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since the toolchain path info lives as a global variable, its not
propagating to the subprocesses that are created to compile the tests in
parallel. This change manually passes these global variables and then
reassigns them.
This seems to only be an issue with the IAR compiler, however I haven't thoroughly tested every environemnt and every compiler.
Status
READY
Migrations
If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.
NO
Todos
Steps to test or reproduce
On a machine with the IAR compiler in the system PATH (
iccarm.exe), runmbed test --compile -m K64F -t IAR. It will complete the library build but fail to build any tests.Switch to these changes and the same command should complete successfully.
@maclobdell This may explain some of the issues you were seeing