New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bd: Fix missing const attributes on functions #3866

Merged
merged 1 commit into from Mar 9, 2017

Conversation

Projects
None yet
5 participants
@geky
Member

geky commented Mar 1, 2017

From review for #3762, several of the "getter" functions in the block device had the const attribute added. However, we forgot a few, which is especially annoying if they depend on each other.

cc @simonqhughes, @0xc0170

@geky geky added the needs: review label Mar 1, 2017

@0xc0170

0xc0170 approved these changes Mar 2, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 2, 2017

/morph test-nightly

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Mar 2, 2017

@mbed-bot

This comment has been minimized.

mbed-bot commented Mar 2, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1615

Test failed!

@bridadan

This comment has been minimized.

Contributor

bridadan commented Mar 2, 2017

I believe for the last run a HEXIWEAR had been knocked offline as the issue persisted in other CI runs. I have reset it so hopefully the same problem won't affect this run.

/morph test-nightly

@mbed-bot

This comment has been minimized.

mbed-bot commented Mar 2, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test-nightly

Output

mbed Build Number: 1619

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Mar 3, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 6, 2017

retest uvisor

@geky

This comment has been minimized.

Member

geky commented Mar 7, 2017

LGTM?

@simonqhughes

This comment has been minimized.

Contributor

simonqhughes commented Mar 8, 2017

Please confirm the spif-driver test

https://github.com/ARMmbed/spiflash-driver/blob/master/TESTS/block_device/spif/main.cpp

works with the new changes? If yes, then its OK to me to merge.

@geky

This comment has been minimized.

Member

geky commented Mar 8, 2017

Can confirm, the spiflash-driver repo and i2ceeprom-driver repo have both been updated to match this pr (tested locally)

@0xc0170 0xc0170 merged commit 7a04d58 into ARMmbed:master Mar 9, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test-nightly Job has started
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment