Issue 3763: Reduce heap allocation in the GCC linker file #4014
Conversation
Signed-off-by: Mahadevan Mahesh <Mahesh.Mahadevan@nxp.com>
|
@mmahadevan108 How did you test this patch? |
|
I'm OK with the change but this does not fix the Issue #3978 |
|
Note that it is the On K64F the Also K64F linker file seems to have all sorts of uVisor related configs, can/should these be made to match? |
|
@SeppoTakalo . Thanks for testing. I will make a separate pull request to move .bss to data_2 Section. |
|
Tested using the mbed-os tests. |
| __stack_size__ = 0x400; | ||
|
|
||
| /* This is the guaranteed minimum available heap size for an application. When | ||
| * uVisor is enabled, this is also the maximum available heap size. The |
There was a problem hiding this comment.
uvisor is not supported for these targets in this patch (most of them) ,and the comment makes reference to it. Shall be removed?
There was a problem hiding this comment.
I left this allocation in heap in place just in case we decide to have uvisor on these targets in future.
| __heap_size__ = 0x10000; | ||
| /* With the RTOS in use, this does not affect the main stack size. The size of | ||
| * the stack where main runs is determined via the RTOS. */ | ||
| __stack_size__ = 0x400; |
There was a problem hiding this comment.
I believe I asked already, just to be certain - this has no affect for mbed 2 apps (no RTOS) ? As its for GCC
There was a problem hiding this comment.
Yes the mbed 2 tests with GCC work after this change.
|
@0xc0170 are you happy review comments are addressed ? |
Yes, we will fix stack sizes separately for all targets. |
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
|
Anything else needed on this one? |
LGTM |
Ports for Upcoming Targets 3841: Add nRf52840 target ARMmbed/mbed-os#3841 3992: Introducing UBLOX_C030 platform. ARMmbed/mbed-os#3992 Fixes and Changes 3951: [NUCLEO_F303ZE] Correct ARDUINO pin ARMmbed/mbed-os#3951 4021: Fixing a macro to detect when RTOS was in use for the NRF52840_DK ARMmbed/mbed-os#4021 3979: KW24D: Add missing SPI defines and Arduino connector definitions ARMmbed/mbed-os#3979 3990: UBLOX_C027: construct a ticker-based wait, rather than calling wait_ms(), in the ARMmbed/mbed-os#3990 4003: Fixed OBOE in async serial tx for NRF52 target, fixes #4002 ARMmbed/mbed-os#4003 4012: STM32: Correct I2C master error handling ARMmbed/mbed-os#4012 4020: NUCLEO_L011K4 remove unsupported tool chain files ARMmbed/mbed-os#4020 4065: K66F: Move bss section to m_data_2 Section ARMmbed/mbed-os#4065 4014: Issue 3763: Reduce heap allocation in the GCC linker file ARMmbed/mbed-os#4014 4030: [STM32L0] reduce IAR heap and stack size for small targets ARMmbed/mbed-os#4030 4109: NUCLEO_L476RG : minor serial pin update ARMmbed/mbed-os#4109 3982: Ticker - kl25z bugfix for handling events in the past ARMmbed/mbed-os#3982
Reduce heap allocation in the GCC linker file, this should address the below issues.
#3978
#3763
Status
**READY