New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

KW24D: Add missing SPI defines and Arduino connector definitions #3979

Merged
merged 1 commit into from Mar 29, 2017

Conversation

Projects
None yet
4 participants
@mmahadevan108
Contributor

mmahadevan108 commented Mar 21, 2017

Add missing SPI defines and Arduino connector definitions

Status

**READY

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Mar 21, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 22, 2017

How was this tested?

Please look at Travis failure (look at the CI results once you submit a pull request).

Executing: python tools/build.py -m KL27Z -t GCC_ARM -j 4 -c --silent --dsp --rtos --usb

/home/travis/build/ARMmbed/mbed-os/targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_KL27Z/TARGET_FRDM/PeripheralPins.c:102:6: error: 'PTB11' undeclared here (not in a function)

     {PTB11 , SPI_1, 2},

      ^

/home/travis/build/ARMmbed/mbed-os/targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_KL27Z/TARGET_FRDM/PeripheralPins.c:147:6: error: 'PTB10' undeclared here (not in a function)

     {PTB10 , SPI_1, 2},

      ^

/home/travis/build/ARMmbed/mbed-os/targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_KL27Z/TARGET_FRDM/PeripheralPins.c:147:5: error: initializer element is not constant

     {PTB10 , SPI_1, 2},

     ^

/home/travis/build/ARMmbed/mbed-os/targets/TARGET_Freescale/TARGET_MCUXpresso_MCUS/TARGET_KL27Z/TARGET_FRDM/PeripheralPins.c:147:5: error: (near initialization for 'PinMap_SPI_SSEL[0].pin')

Completed in: (0.65)s

@0xc0170 0xc0170 added the needs: work label Mar 22, 2017

@sg-

This comment has been minimized.

Member

sg- commented Mar 22, 2017

@mmahadevan108 Looks like there are changes to a KL27 target but this PR is about KW24. Please have a look

KW24D: Add missing SPI defines and Arduino connector definitions
Signed-off-by: Mahadevan Mahesh <Mahesh.Mahadevan@nxp.com>

@mmahadevan108 mmahadevan108 force-pushed the NXPmicro:KW24D_Pindefines branch to c1ed01e Mar 23, 2017

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Mar 23, 2017

Thank you. It was a miss on my part, I have updated the patch.

@mmahadevan108

This comment has been minimized.

Contributor

mmahadevan108 commented Mar 28, 2017

Does the updated patch look fine?

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 29, 2017

/morph test

@0xc0170 0xc0170 added needs: CI and removed needs: work labels Mar 29, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Mar 29, 2017

Does the updated patch look fine?

Yes, waiting for CI to complete

@mbed-bot

This comment has been minimized.

mbed-bot commented Mar 29, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1780

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Mar 29, 2017

@sg- sg- merged commit b25eaf5 into ARMmbed:master Mar 29, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@mmahadevan108 mmahadevan108 deleted the NXPmicro:KW24D_Pindefines branch Mar 30, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment