New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

u-blox ODIN driver v1.3 rc2 for mbed OS 5 #4338

Merged
merged 11 commits into from May 19, 2017

Conversation

Projects
None yet
7 participants
@andreaslarssonublox
Contributor

andreaslarssonublox commented May 18, 2017

Description

Bug fixes for the u-blox ODIN-W2 driver:

  • GCC reports wrong size #3598
  • SD card not working with WiFi #4257
  • Default connection timeout to 20 sec instead of infinite #3431
  • Removed dependencies to lower RTOS C API
  • New/delete works for the OdinWiFiInterface class
  • The driver should be compilable with STM32F4 cube v1.16.0 #4299

The driver has been built with this mbed-os commit:
SHA-1: 8f29517

Status

READY

Migrations

NO

Related PRs

NO

Todos

NO

Deploy notes

None

Steps to test or reproduce

N/A

Test results

mbed_os_test_results_arm.txt
mbed_os_test_results_gcc_arm.txt
mbed_os_test_results_iar.txt

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 18, 2017

/morph test

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 18, 2017

Just to be certain, all is backward compatible, no breaking change here?

What about the new cmsis5 update - will it require a new update?

@andreaslarssonublox

This comment has been minimized.

Contributor

andreaslarssonublox commented May 18, 2017

Yes, there should not be any API changes. We have removed dependencies to lower layer RTOS stuff so it should work with CMSIS5.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented May 18, 2017

Yes, there should not be any API changes.

I noticed some code restructure, like removal in the structures, so this should go into 5.5 ?

@0xc0170 0xc0170 added the needs: CI label May 18, 2017

@andreaslarssonublox

This comment has been minimized.

Contributor

andreaslarssonublox commented May 18, 2017

The OdinWiFiInterface.h has a slight change, the error code is returned for set_timeout , before it was void. Also there is a default timeout on connection setup now, before it was infinite.
The other C API header files have some changes but the end user should use the C++ API.
For us it can go in now but if you think that the set_timeout is a too big change it can also wait I guess.

@mbed-bot

This comment has been minimized.

mbed-bot commented May 18, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 256

Test failed!

@sg-

This comment has been minimized.

Member

sg- commented May 18, 2017

@studavekar What version DAPLink is on that board? The version number used to be char 3...7

| K22F           | K22F[0]              | COM9        | I:          | 0231000026334e45003f400d5e0e00294eb1000097969900 |
@studavekar

This comment has been minimized.

Collaborator

studavekar commented May 18, 2017

The version of DAP link was 0241, have updated to 0243

| K22F          | K22F[0]              | G:          | COM22       | 0231000026334e45003f400d5e0e00294eb1000097969900 | 0243
@studavekar

This comment has been minimized.

Collaborator

studavekar commented May 18, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented May 19, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 268

All builds and test passed!

@JanneKiiskila

This comment has been minimized.

Contributor

JanneKiiskila commented May 19, 2017

Please merge this ASAP, so that we can verify the Cloud Client.
@0xc0170 @geky

@0xc0170 0xc0170 merged commit 5d0ce3c into ARMmbed:master May 19, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@JanneKiiskila

This comment has been minimized.

Contributor

JanneKiiskila commented May 19, 2017

Thank you @0xc0170 and @andreaslarssonublox - I have verified the mbed Cloud Client now works with UBLOX ODIN EVK W2 over WiFi with those changes.

Starting example client
Start simple mbed Cloud Client
Resets storage to an empty state
Start developer flow
[EasyConnect] IPv4 mode
[EasyConnect] Using WiFi (ODIN) 
[EasyConnect] Connecting to WiFi jannek.iki.fi
[EasyConnect] Connected to Network successfully
[EasyConnect] IP address 192.168.1.221
[EasyConnect] MAC address d4:ca:6e:70:88:2d

Client registered

Endpoint Name: 015c20dcb95500000000000100100141
Device Id: 015c20dcb95500000000000100100141
increment resource value, new value of resource is 1
increment resource value, new value of resource is 2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment