Fix i2c communication with pcf8574 on stm32 targets of f1, f2, f4 and l1 families #4365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@LMESTM I'm not sure that I know what "c pcf f1 f2 f4 l1" is supposed to mean. Could you update the title? |
LMESTM
changed the title
|
@theotherjimmy - sure, hope it's better now |
|
@LMESTM Much better! I now understand what this PR does! |
0xc0170
approved these changes
May 25, 2017
|
/morph test |
Result: ABORTEDYour command has finished executing! Here's what you wrote!
|
|
Sorry for the ABORT everyone, need to prioritize a few PR CI jobs for the upcoming release. |
|
@LMESTM Looks like this needs a rebase please. |
|
@LMESTM can you resolve the conflict? |
LMESTM
force-pushed
the
fix_i2C_pcf_F1F2F4L1
branch
from
c6e8057
to
9d6b203
Compare
There were still side effects, in particular on I2C master slave test, when setting by default the Pin Speed for F1 family. So for F1 family, let's do it only in case of Output which is the only case where this actually applies on this family.
As reported in issue ARMmbed#4214, there are seen issues seen first on NUCLEO_F103RB in case of successive Reads of 1 byte at a time. This issue is due to a wrong state management in the end of read sequence. Also F1 i2c driver was not fully aligned to others, which is updated here.
LMESTM
force-pushed
the
fix_i2C_pcf_F1F2F4L1
branch
from
9d6b203
to
a1f7a36
Compare
|
rebased again ... |
|
cc @Willem23 |
0xc0170
approved these changes
Jun 5, 2017
|
/morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
adbridge
added
ready for merge
release-version: 5.4.7
release-version: 5.5.0-rc2
and removed
needs: CI
ready for merge
labels
|
Some of the changes are dependent on #4402 which contains API changes and was thus targeted at 5.5.0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue reported in #4214
This requires an update in HAL but also a fix in the GPIO management of F1 family targets
Status
READY
Tests
Test reported in #4214 is passed ok with the fix.
CI test cases passed ok as well on all 4 families where fix applies:
+-------------------+---------------+---------------+--------+--------------------+-------------+
| target | platform_name | test suite | result | elapsed_time (sec) | copy_method |
+-------------------+---------------+---------------+--------+--------------------+-------------+
| NUCLEO_F091RC-ARM | NUCLEO_F091RC | tests-api-i2c | OK | 59.24 | shell |
| NUCLEO_F103RB-ARM | NUCLEO_F103RB | tests-api-i2c | OK | 73.24 | shell |
| NUCLEO_F207ZG-ARM | NUCLEO_F207ZG | tests-api-i2c | OK | 58.66 | shell |
| NUCLEO_F303ZE-ARM | NUCLEO_F303ZE | tests-api-i2c | OK | 61.36 | shell |
| NUCLEO_F446RE-ARM | NUCLEO_F446RE | tests-api-i2c | OK | 59.19 | shell |
| NUCLEO_F767ZI-ARM | NUCLEO_F767ZI | tests-api-i2c | OK | 59.74 | shell |
| NUCLEO_L073RZ-ARM | NUCLEO_L073RZ | tests-api-i2c | OK | 63.78 | shell |
| NUCLEO_L152RE-ARM | NUCLEO_L152RE | tests-api-i2c | OK | 59.62 | shell |
| NUCLEO_L476RG-ARM | NUCLEO_L476RG | tests-api-i2c | OK | 58.96 | shell |
+-------------------+---------------+---------------+--------+--------------------+-------------+