New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable crypto HW acceleration for UBLOX_EVK_ODIN_W2 #4750

Merged
merged 2 commits into from Jul 31, 2017

Conversation

Projects
None yet
5 participants
@andreaslarssonublox
Contributor

andreaslarssonublox commented Jul 12, 2017

Description

Enable hardware crypto for UBLOX_EVK_ODIN_W2. I'm not 100% sure if changing the folder holding mbedtls_device.h configuration file is the right thing. I guess that we don't want to have one configuration per target but rather have it one level up i.e. at STM32F439xI level.
Should be reviewed by someone form ST since we're changing the target hierarchy somewhat.
@LMESTM
@0xc0170

Status

READY

Migrations

If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.

NO

Related PRs

None

Todos

None

Deploy notes

None

Steps to test or reproduce

N/A

Test results

mbed_test_odin_arm_log.txt
mbed_test_odin_gcc_log.txt
mbed_test_odin_iar_log.txt

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 12, 2017

@andreaslarssonublox The title of this PR is great, but a little ambiguous. Could you change it to "Enable crypto HW acceleration for UBLOX_EVK_ODIN_W2" (my addition in bold)?

@andreaslarssonublox andreaslarssonublox changed the title from Enable HW acceleration for UBLOX_EVK_ODIN_W2 to Enable crypto HW acceleration for UBLOX_EVK_ODIN_W2 Jul 13, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 17, 2017

@LMESTM Happy with this changeset?

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jul 24, 2017

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Jul 24, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 25, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 878

Build failed!

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jul 26, 2017

/morph test

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Jul 27, 2017

/morph echo

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 27, 2017

I recieved your comment! Here's what you wrote!

/morph echo

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Jul 27, 2017

The above failure was due to CI error re-triggering

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 28, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 903

All builds and test passed!

@mbed-bot

This comment has been minimized.

mbed-bot commented Jul 28, 2017

Result: SUCCESS

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 904

All builds and test passed!

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Jul 28, 2017

@theotherjimmy theotherjimmy merged commit 50c616e into ARMmbed:master Jul 31, 2017

4 checks passed

Cam-CI uvisor Build & Test Success
Details
ci/morph-test Job has completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment