Enable crypto HW acceleration for UBLOX_EVK_ODIN_W2 #4750
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@andreaslarssonublox The title of this PR is great, but a little ambiguous. Could you change it to "Enable crypto HW acceleration for UBLOX_EVK_ODIN_W2" (my addition in bold)? |
andreaslarssonublox
changed the title
|
@LMESTM Happy with this changeset? |
0xc0170
approved these changes
Jul 24, 2017
|
/morph test |
Result: FAILUREYour command has finished executing! Here's what you wrote!
OutputBuild failed! |
|
/morph test |
|
/morph echo |
|
I recieved your comment! Here's what you wrote!
|
|
The above failure was due to CI error re-triggering /morph test |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Result: SUCCESSYour command has finished executing! Here's what you wrote!
OutputAll builds and test passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Enable hardware crypto for UBLOX_EVK_ODIN_W2. I'm not 100% sure if changing the folder holding mbedtls_device.h configuration file is the right thing. I guess that we don't want to have one configuration per target but rather have it one level up i.e. at STM32F439xI level.
Should be reviewed by someone form ST since we're changing the target hierarchy somewhat.
@LMESTM
@0xc0170
Status
READY
Migrations
If this PR changes any APIs or behaviors, give a short description of what API users should do when this PR is merged.
NO
Related PRs
None
Todos
None
Deploy notes
None
Steps to test or reproduce
N/A
Test results
mbed_test_odin_arm_log.txt
mbed_test_odin_gcc_log.txt
mbed_test_odin_iar_log.txt