Unify mbed OS tools testing style with what's used in mbed-ls, htrun, greentea #4984
Conversation
Is this still in devel? I'll have a look tomorrow. |
|
Actually, no. It's all working now. I'll update the description. |
| root_dir = abspath(dirname(__file__)) | ||
|
|
||
| @pytest.mark.parametrize("name", filter(lambda d: is_test(join(root_dir, d)), | ||
| os.listdir(root_dir))) |
There was a problem hiding this comment.
formatting here is a bit weird?
There was a problem hiding this comment.
Yes it is. I'll have to get on that.
There was a problem hiding this comment.
This file has been deleted in this branch....
| @@ -0,0 +1,12 @@ | |||
|
|
|||
| { | |||
| "f": { | |||
There was a problem hiding this comment.
What are 'f' and 'b2' ? Don't seem very meaningful names ?
| @@ -0,0 +1,6 @@ | |||
|
|
|||
| { | |||
| @@ -0,0 +1,6 @@ | |||
|
|
|||
| { | |||
|
|
||
| expected_results = { | ||
| { |
tools/test/config/config_test.py
Outdated
| when both are specified | ||
|
|
||
| :param mock_json_file_to_dict: mock of function json_file_to_dict | ||
| :param _: patch of function _process_config_and_overrides (not tested) |
| for target in named_targets: | ||
| assert target.device_name in cache.index,\ | ||
| ("Target %s contains invalid device_name %s" % | ||
| (target.name, target.device_name)) |
There was a problem hiding this comment.
That's actually also correct.
tools/test/targets/target_test.py
Outdated
|
|
||
| @contextmanager | ||
| def temp_target_file(extra_target, json_filename='custom_targets.json'): | ||
| """Create an extra targets temp file in a context manager""" |
| """ | ||
| Test find_tests for correct use of app_config |
| @pytest.mark.parametrize("app_config", ["app_config", None]) | ||
| def test_find_tests_app_config(build_path, target, toolchain_name, app_config): | ||
| """ | ||
| Test find_tests for correct use of app_config |
|
@adbridge Please rereview |
tools/test/memap/memap_test.py
Outdated
| @@ -191,8 +201,10 @@ def test_generate_output_csv_ci(memap_parser, tmpdir, depth): | |||
| """ | |||
| Test ensures that an output of type "csv-ci" can be generated correctly | |||
|
|
|||
| :return: | |||
| :param memap_parser: Mocked parser | |||
| :param tmpdir: a temporary directory | |||
There was a problem hiding this comment.
Might be better to say why there is even a temporary directory? Otherwise not that helpful a parameter description.
There was a problem hiding this comment.
Yes of course.
tools/test/memap/memap_test.py
Outdated
| @@ -179,8 +186,11 @@ def test_generate_output_table(memap_parser, depth): | |||
| def test_generate_output_json(memap_parser, tmpdir, depth): | |||
| """ | |||
| Test that an output of type "json" can be generated correctly | |||
| :param memap_parser: Mocked parser | |||
| :param tmpdir: a temporary directory | |||
theotherjimmy
force-pushed
the
unify-unit-tests
branch
from
9f8838c
to
4a937fe
Compare
|
@adbridge I think I addressed your review comments. Could you take a look? |
Wipe out all blank lines in json:
find tools/test -name 'test_data.json' | xargs sed -i -e '/^$/d'
Move all start braces back a space:
find tools/test -name 'test_data.json' | xargs sed -i -e "s/^ {/{/"
|
Changes Unknown when pulling 399b6ac on theotherjimmy:unify-unit-tests into ** on ARMmbed:master**. |
|
Changes Unknown when pulling 9d0e8ab on theotherjimmy:unify-unit-tests into ** on ARMmbed:master**. |
theotherjimmy
force-pushed
the
unify-unit-tests
branch
from
6f1d1b6
to
944b604
Compare
theotherjimmy
force-pushed
the
unify-unit-tests
branch
from
944b604
to
6bf7718
Compare
|
Woooooo! We only need to run Travis on this one (it only affects the unit tests) and Travis passed. |
Also enables coverage numbers!
Converts our usage of testing frameworks to use py.test.
Ready
This should only need to be tested by travis CI.