Test set for LowPowerTicker class #5047

maciejbocianski · 2017-09-07T13:20:02Z

Description

New test suite for LowPowerTicker class

Status

READY

##Blocked
#5185 fixedy by #5347 (merged)
#5150 fixedy by #5347 (merged)

0xc0170 · 2017-09-07T13:28:42Z

cc @bulislaw @c1728p9

0xc0170 · 2017-09-07T14:15:16Z

TESTS/mbed_drivers/lp_ticker/main.cpp

+#define TICKER_COUNT 16
+
+Semaphore ticker_callback_sem(0, 1);
+bool ticker_callback_flag;


assume this is also candidate for volatile?

0xc0170 · 2017-09-07T14:19:58Z

TESTS/mbed_drivers/lp_ticker/main.cpp

+    TestTicker ticker[TICKER_COUNT];
+
+    multi_counter = 0;
+    for(int i = 0; i < TICKER_COUNT; i++) {


a nit: for ( space there

0xc0170 · 2017-09-07T14:20:07Z

TESTS/mbed_drivers/lp_ticker/main.cpp

+            ticker[i].detach();
+    }
+
+    //TEST_ASSERT_EQUAL(TICKER_COUNT, multi_counter);


no dead code

0xc0170 · 2017-09-07T14:21:43Z

TESTS/mbed_drivers/lp_ticker/main.cpp

+    Case("Test multi ticker", test_multi_ticker),
+};
+
+utest::v1::status_t greentea_test_setup(const size_t number_of_cases) {


{ new line for function body

bulislaw · 2017-09-07T18:34:15Z

TESTS/mbed_drivers/lp_ticker/main.cpp

+
+using namespace utest::v1;
+
+#define TestTicker LowPowerTicker


I don't like that, it's confusing. Is there a particular reason you are doing that?

bulislaw · 2017-09-07T18:37:12Z

TESTS/mbed_drivers/lp_ticker/main.cpp

+}
+
+
+/** Test many tickers run simultaneously


This test case does something else than described here.

bulislaw · 2017-09-07T18:38:27Z

TESTS/mbed_drivers/lp_ticker/main.cpp

+
+/** Test multi callback time
+
+    Given an Ticker


just a nit: a Ticker

bulislaw · 2017-09-07T18:38:56Z

TESTS/mbed_drivers/lp_ticker/main.cpp

+
+    Given an Ticker
+    When schedule callback
+    Then ticker properly execute callback multiple time


time -> times

bulislaw · 2017-09-07T18:41:51Z

TESTS/mbed_drivers/lp_ticker/main.cpp

+/** Test multi callback time
+
+    Given an Ticker
+    When schedule callback


It's not only once it's scheduled: When the callback is attached multiple times

bulislaw · 2017-09-07T18:45:54Z

TESTS/mbed_drivers/lp_ticker/main.cpp

+/** Test if detach cancel scheduled callback event
+
+    Given an Ticker with scheduled callback
+    When schedule is cancelled


schedule is not really something that exists in Ticker terms, I know what you mean, but we could use something like:
Given a Ticker with callback attached
When the callback is detached
Then the callback is not being called

Also your test does more than described here.

bulislaw · 2017-09-07T18:46:26Z

TESTS/mbed_drivers/lp_ticker/main.cpp

+
+/** Test single callback time via attach
+
+    Given an Ticker


That should be rewritten, some examples in previous tests.

bulislaw · 2017-09-07T18:49:12Z

TESTS/mbed_drivers/lp_ticker/main.cpp

+    ticker.detach();
+    int time_diff = timer.read_us();
+
+    printf("TOLERANCE: %d\n", (uint32_t)TOLERANCE);


Lets not print anything if not needed.

bulislaw · 2017-09-07T18:49:40Z

TESTS/mbed_drivers/lp_ticker/main.cpp

+
+/** Test single callback time via attach_us
+
+    Given an Ticker


Could you rewrite this, examples in previous tests.

bulislaw · 2017-09-07T18:50:23Z

TESTS/mbed_drivers/lp_ticker/main.cpp

+    ticker.detach();
+    int time_diff = timer.read_us();
+
+    printf("TOLERANCE: %d\n", (uint32_t)TOLERANCE);


Lets not print if we don't have to.

0xc0170 · 2017-09-08T11:42:06Z

@theotherjimmy @studavekar To be aware, I found travis failing for some recent PR, with InsecurePlatformWarning. I restarted it here, please have a look once finished if it is still there. Has anything chagned again, or new module update somewhere causing this?

c1728p9 · 2017-09-08T21:17:07Z

Why is this being tested at the driver layer rather than the HAL layer? The HAL specification will require test cases that will make these redundant.

bulislaw · 2017-09-11T08:29:28Z

I think that should be done on both layers, drivers and HAL (when we finish drafting the new specification).

theotherjimmy · 2017-09-25T15:19:24Z

@maciejbocianski @bulislaw What's the status of this PR?

maciejbocianski · 2017-09-26T07:46:37Z

@theotherjimmy @bulislaw
test fails on K64F
issue #5185

0xc0170 · 2017-09-26T08:00:34Z

@theotherjimmy @bulislaw
test fails on K64F

Is this the only failure that we should expect. This means this is waiting for the fix. cc @mmahadevan108 for visibility (already tagged in the issue)

maciejbocianski · 2017-09-26T08:34:24Z

Yes, it was the only failure from tested pool k64f, nrf51_dk, nucleo_f070rb, nucleo_f429zi,

mbed-ci · 2017-10-11T12:51:09Z

Build : FAILURE

Build number : 113
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5047/

mbed-ci · 2017-10-11T15:38:36Z

Build : SUCCESS

Build number : 122
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5047/

Triggering tests

/test mbed-os

0xc0170 · 2017-10-19T15:11:36Z

K64F should be fixed via #5347 , what about the rest?

bulislaw · 2017-10-27T15:43:22Z

@maciejbocianski what's the status here?

maciejbocianski · 2017-10-27T15:50:30Z

I think it's ready and waiting for morph,
at least not blocked by any issue

bulislaw · 2017-10-27T15:53:45Z

/morph build

mbed-ci · 2017-10-27T16:30:51Z

Build : SUCCESS

Build number : 359
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5047/

Triggering tests

/morph test
/morph uvisor-test

mbed-ci · 2017-10-27T16:59:29Z

Build : SUCCESS

Build number : 361
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5047/

Triggering tests

/morph test
/morph uvisor-test

studavekar · 2017-10-30T15:04:13Z

/morph test

mbed-ci · 2017-10-30T16:14:21Z

Test : SUCCESS

Build number : 179
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5047/179

adbridge · 2017-10-31T12:04:25Z

@c1728p9 @bulislaw Are you guys happy this has been fully reviewed? I can't see any evidence of a review being signed off here?

0xc0170 added the needs: review label Sep 7, 2017

0xc0170 reviewed Sep 7, 2017

View reviewed changes

bulislaw reviewed Sep 7, 2017

View reviewed changes

maciejbocianski force-pushed the lp_ticker_tests branch from 228cf1a to 92bca03 Compare September 8, 2017 06:57

maciejbocianski force-pushed the lp_ticker_tests branch from 92bca03 to 459a801 Compare September 12, 2017 14:13

maciejbocianski force-pushed the lp_ticker_tests branch from 459a801 to bafe50e Compare September 20, 2017 09:30

0xc0170 added needs: work and removed needs: review labels Sep 26, 2017

0xc0170 added the needs: preceding PR label Sep 26, 2017

maciejbocianski force-pushed the lp_ticker_tests branch from bafe50e to cfc5121 Compare October 11, 2017 10:45

Test set for LowPowerTicker class

9fb4fd0

maciejbocianski force-pushed the lp_ticker_tests branch from cfc5121 to 9fb4fd0 Compare October 11, 2017 13:01

0xc0170 removed the needs: work label Oct 19, 2017

bulislaw added needs: CI and removed needs: preceding PR labels Oct 27, 2017

bulislaw approved these changes Nov 1, 2017

View reviewed changes

theotherjimmy added ready for merge and removed needs: CI labels Nov 1, 2017

theotherjimmy merged commit 1454e6b into ARMmbed:master Nov 2, 2017

theotherjimmy added release-version: 5.6.4 and removed ready for merge labels Nov 2, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Test set for LowPowerTicker class #5047

Test set for LowPowerTicker class #5047

maciejbocianski commented Sep 7, 2017 •

edited

Loading

0xc0170 commented Sep 7, 2017

0xc0170 Sep 7, 2017

0xc0170 Sep 7, 2017

0xc0170 Sep 7, 2017

0xc0170 Sep 7, 2017

bulislaw Sep 7, 2017

bulislaw Sep 7, 2017

bulislaw Sep 7, 2017

bulislaw Sep 7, 2017

bulislaw Sep 7, 2017

bulislaw Sep 7, 2017

bulislaw Sep 7, 2017

bulislaw Sep 7, 2017

bulislaw Sep 7, 2017

bulislaw Sep 7, 2017

0xc0170 commented Sep 8, 2017

c1728p9 commented Sep 8, 2017

bulislaw commented Sep 11, 2017

theotherjimmy commented Sep 25, 2017

maciejbocianski commented Sep 26, 2017

0xc0170 commented Sep 26, 2017

maciejbocianski commented Sep 26, 2017

mbed-ci commented Oct 11, 2017

mbed-ci commented Oct 11, 2017

0xc0170 commented Oct 19, 2017

bulislaw commented Oct 27, 2017

maciejbocianski commented Oct 27, 2017

bulislaw commented Oct 27, 2017

mbed-ci commented Oct 27, 2017

mbed-ci commented Oct 27, 2017

studavekar commented Oct 30, 2017

mbed-ci commented Oct 30, 2017

adbridge commented Oct 31, 2017

Test set for LowPowerTicker class #5047

Test set for LowPowerTicker class #5047

Conversation

maciejbocianski commented Sep 7, 2017 • edited Loading

Description

Status

0xc0170 commented Sep 7, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

0xc0170 commented Sep 8, 2017

c1728p9 commented Sep 8, 2017

bulislaw commented Sep 11, 2017

theotherjimmy commented Sep 25, 2017

maciejbocianski commented Sep 26, 2017

0xc0170 commented Sep 26, 2017

maciejbocianski commented Sep 26, 2017

mbed-ci commented Oct 11, 2017

mbed-ci commented Oct 11, 2017

Triggering tests

0xc0170 commented Oct 19, 2017

bulislaw commented Oct 27, 2017

maciejbocianski commented Oct 27, 2017

bulislaw commented Oct 27, 2017

mbed-ci commented Oct 27, 2017

Triggering tests

mbed-ci commented Oct 27, 2017

Triggering tests

studavekar commented Oct 30, 2017

mbed-ci commented Oct 30, 2017

adbridge commented Oct 31, 2017

maciejbocianski commented Sep 7, 2017 •

edited

Loading