Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

STM32: Initialize RTC structures at init phase. #5269

Merged
merged 2 commits into from
Oct 13, 2017
Merged

STM32: Initialize RTC structures at init phase. #5269

merged 2 commits into from
Oct 13, 2017

Conversation

bcostm
Copy link
Contributor

@bcostm bcostm commented Oct 6, 2017 •
edited
Loading

Description

  • Initialize the structures at init phase to zero.
  • Initialize the handle State variable to RESET state.

Solve ST internal RTC test on NUCLEO_F030R8 with GCC_ARM.

Status

READY

Migrations

NO

Related PRs

Structures initialization also done in PR #5188 and #5263

ST_INTERNAL_REF 36019

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 9, 2017

@LMESTM @adustm @jeromecoutant review?

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 9, 2017

retest uvisor

LMESTM
LMESTM approved these changes Oct 9, 2017
View reviewed changes
Copy link
Contributor

@LMESTM LMESTM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question for an extra change, but anyway change looks good to me !

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 10, 2017

retest uvisor

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 10, 2017

/morph test

@mbed-bot
Copy link

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1561

Example Build failed!

@bcostm bcostm changed the title STM32: Initialize RTC structures to zero STM32: Initialize RTC structures at init phase. Oct 10, 2017
@bcostm
Copy link
Contributor Author

bcostm commented Oct 10, 2017

I have rebased and added one more commit to initialize the State variable.

@studavekar
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 10, 2017

Build : SUCCESS

Build number : 65
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5269/

Triggering tests

/test mbed-os

@mbed-ci
Copy link

mbed-ci commented Oct 10, 2017

Test : SUCCESS

Build number : 19
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/5269/19

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 11, 2017

retest uvisor

@theotherjimmy theotherjimmy merged commit 8bf2775 into ARMmbed:master Oct 13, 2017
@bcostm bcostm deleted the fix_rtc_struct_init branch October 16, 2017 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@jeromecoutant jeromecoutant jeromecoutant approved these changes

@adustm adustm adustm approved these changes

@LMESTM LMESTM LMESTM approved these changes

Assignees
No one assigned
Labels
release-version: 5.6.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@bcostm @0xc0170 @mbed-bot @studavekar @mbed-ci @jeromecoutant @adustm @LMESTM @theotherjimmy