New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32: Initialize RTC structures at init phase. #5269

Merged
merged 2 commits into from Oct 13, 2017

Conversation

Projects
None yet
9 participants
@bcostm
Contributor

bcostm commented Oct 6, 2017

Description

  • Initialize the structures at init phase to zero.
  • Initialize the handle State variable to RESET state.

Solve ST internal RTC test on NUCLEO_F030R8 with GCC_ARM.

Status

READY

Migrations

NO

Related PRs

Structures initialization also done in PR #5188 and #5263

ST_INTERNAL_REF 36019

@0xc0170

0xc0170 approved these changes Oct 6, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 9, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 9, 2017

retest uvisor

@LMESTM

LMESTM approved these changes Oct 9, 2017

One question for an extra change, but anyway change looks good to me !

@adustm

adustm approved these changes Oct 10, 2017

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Oct 10, 2017

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 10, 2017

retest uvisor

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 10, 2017

/morph test

@mbed-bot

This comment has been minimized.

mbed-bot commented Oct 10, 2017

Result: FAILURE

Your command has finished executing! Here's what you wrote!

/morph test

Output

mbed Build Number: 1561

Example Build failed!

@bcostm bcostm changed the title from STM32: Initialize RTC structures to zero to STM32: Initialize RTC structures at init phase. Oct 10, 2017

@bcostm bcostm force-pushed the bcostm:fix_rtc_struct_init branch Oct 10, 2017

@bcostm bcostm force-pushed the bcostm:fix_rtc_struct_init branch to 992722d Oct 10, 2017

@bcostm

This comment has been minimized.

Contributor

bcostm commented Oct 10, 2017

I have rebased and added one more commit to initialize the State variable.

@studavekar

This comment has been minimized.

Collaborator

studavekar commented Oct 10, 2017

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 10, 2017

Build : SUCCESS

Build number : 65
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5269/

Triggering tests

/test mbed-os

@mbed-ci

This comment has been minimized.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 11, 2017

retest uvisor

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Oct 12, 2017

@theotherjimmy theotherjimmy merged commit 8bf2775 into ARMmbed:master Oct 13, 2017

5 checks passed

Cam-CI uvisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details

@bcostm bcostm deleted the bcostm:fix_rtc_struct_init branch Oct 16, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment