Update CMSIS/RTX with Cortex-A support #5312

bulislaw · 2017-10-12T19:59:37Z

Description

This PR introduces updates to RTX/CMSIS and brings Cortex-A support back into mbed OS

Status

IN DEVELOPMENT

ToDo

Validation
uVisor sanity check
v8 sanity check
IAR support for Cortex-A

CC
@Patater could you have a look at my merges of your old uVisor commits
@deepikabhavnani could you see how much this breaks v8 support? and possibly try to fix it?

This includes Cortex A support and directory reshuffle.

bulislaw · 2017-10-12T20:01:27Z

/morph test

pan- · 2017-10-12T20:23:38Z

rtos/TARGET_CORTEX/rtx4/cmsis_os.h

@@ -438,23 +438,23 @@ uint32_t osKernelSysTick (void);
 /// \param         instances     number of possible thread instances.
 /// \param         stacksz       stack size (in bytes) requirements for the thread function.
 #if defined (osObjectsExternal)  // object is external
-#define osThreadDef(name, priority, instances, stacksz) \
+#define osThreadDef(name, priority, stacksz) \


Could you remove the instances parameter from the function documentation ?

pan- · 2017-10-12T20:31:23Z

Why is there two versions of the heap and stack test, one in the root TEST directory and another in the rtos directory ?

bulislaw · 2017-10-12T21:07:30Z

Cause I've copied it instead of moving :) Good catch!

mbed OS used older RTX4 version and with osThreadDef accepting only 3 parameters, to preserve compatibility we hardcode the 'instances' parameter to 1.

This implementation of timer conflicts with the default ptim, we will keep the default and let the timer override the implmenetation if needed.

These tests are not compatible with Cortex A due to __get_MSP usage.

This fixes #4602 issue, mbed_main should be invoked right before the real main

Only set the SVCall priority if uVisor is not present. If uVisor is present, keep using whatever priorities it has already set up.

Add the OsEventObserver mechanism. A client interested in receiving notifications on certain OS events can register to receive notifications with osRegisterForOsEvents. This is useful for clients like the secure memory allocator, which observes thread switching events in order to swap in and out different memory allocator objects.

OsEventObserver objects expect a context to be maintained per thread on their behalf. Add this context to the thread control block and extend the thread creation functions with the ability to supply a context.

adbridge · 2017-10-16T15:29:07Z

@bulislaw what is the status of this now ?

deepikabhavnani · 2017-10-16T15:57:29Z

ARM-software/CMSIS_5#260 pull request should be included for v8, in case it is not merged in CMSIS by 5.7

bulislaw · 2017-10-16T18:07:15Z

That shouldn't be merged, this PR exists as a reference, there's more work that needs to be done by Renesas to reintroduce their platforms.

CMSIS repo does not support pre-processor defines, hence multiple assembly files are added for secure/non-secure and floating point tools. Mbed-os tools do pre-processing of assembly files and defines are handled in tool sections. Hence removing additional assembly files as we can have just one per target.

TomoYamanaka · 2017-10-17T09:29:58Z

@bulislaw
I attempted to build and test uging this PR source code, it did NOT work at all.
To be honest, the code is too much different from my expectation, I faced to many build errors by both ARMCC and GCC_ARM, couldn't reach the test.
This situation is the same as you provided at the end of July (Reference).
I have expected to obtain the build successfully code at least by this PR,
how did you create this PR? (using GR-PEACH? How about was test?)

By the way,
I think that the cause of build error is the lack of reflection from my branch code that I advised at previously.
The applicable three commits are below.

Commit 1
/rtos/rtx5/RTX/Source/rtx_lib.c
/rtos/rtx5/RTX/Source/TOOLCHAIN_GCC/TARGET_CORTEX_A/irq_ca.S
/TESTS/mbedmicro-rtos-mbed/malloc/main.cpp
Commit 2
/cmsis/TARGET_CORTEX_A/
/targets/TARGET_RENESAS/TARGET_RZ_A1H/
Commit 3
/cmsis/TARGET_CORTEX_A/
/targets/TARGET_RENESAS/TARGET_RZ_A1H

For this reason, I ask you to reflect my commits with this PR so that the build can be successfully, and I can test using this PR source code.

@toyowata

Please help me to go ahead with the above.

bulislaw · 2017-10-17T21:57:48Z

This PR is newest version of CMSIS/RTX on top of master of mbed OS. I didn't touch or test GR-Peach code.

bulislaw · 2017-10-17T22:01:28Z

/morph build

mbed-ci · 2017-10-17T22:52:20Z

Build : ABORTED

Build number : 211
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5312/

mbed-ci · 2017-10-17T23:04:16Z

Build : FAILURE

Build number : 212
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5312/

bulislaw · 2017-10-18T14:31:53Z

@studavekar That looks at CI issue: https://mbed-os.mbedcloudtesting.com/job/mbed-os-build-matrix/212/target=ARCH_PRO,toolchain=ARM/console

bulislaw · 2017-10-18T14:33:57Z

/morph build

mbed-ci · 2017-10-18T15:01:05Z

Build : FAILURE

Build number : 230
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/5312/

studavekar · 2017-10-18T15:36:39Z

Doesn't look like an CI issue

        Link: sleep_manager
        [DEBUG] Link: /usr/local/ARM_Compiler_5.06u6/bin/armlink --via /builds/ws/mbed-os-build-matrix/b77abcb4/mbed-os/BUILD/tests/ARCH_PRO/ARM/./TESTS/mbed_hal/sleep_manager/.link_files.txt
        [DEBUG] Return: 1
        [DEBUG] Errors: Error: L6200E: Symbol _mutex_initialize multiply defined (by /builds/ws/mbed-os-build-matrix/b77abcb4/mbed-os/BUILD/tests/ARCH_PRO/ARM/rtos/TARGET_CORTEX/rtx5/RTX/Source/rtx_lib.o and /builds/ws/mbed-os-build-matrix/b77abcb4/mbed-os/BUILD/tests/ARCH_PRO/ARM/rtos/TARGET_CORTEX/mbed_boot.o).
        [DEBUG] Errors: Not enough information to list the image map.
        [DEBUG] Errors: Finished: 1 information, 0 warning and 1 error messages.

Update CMSIS and RTX to 22b68c

8de2dd2

This includes Cortex A support and directory reshuffle.

bulislaw added component: cmsis do not merge needs: work labels Oct 12, 2017

bulislaw self-assigned this Oct 12, 2017

pan- reviewed Oct 12, 2017

View reviewed changes

bulislaw and others added 18 commits October 13, 2017 12:04

RTX: Patch RTX4 to preserve osThreadDef compatibility

d603682

mbed OS used older RTX4 version and with osThreadDef accepting only 3 parameters, to preserve compatibility we hardcode the 'instances' parameter to 1.

RTX: Patch RTX includes to match mbed OS scheme

12cd03d

RTX: Patch RTX so irq_cm4f.s files work with no FPU targets

97833fd

RTOS: Tests: Move memory heap and stack tests from rtos directory

16fc993

RZ_A1H: Fix cmsis header name

97e4ca1

Update CThunk to support new CMSIS Cortex A ops

3efe0d9

Renesas: Add empty mbed_rtx.h

3d89e78

RTX: Remove os_tick_gtim.c

1ff7f92

This implementation of timer conflicts with the default ptim, we will keep the default and let the timer override the implmenetation if needed.

Update definitions of CPSR modes

ab94d0e

Disable heap and stack tests for Cortex A

654a62e

These tests are not compatible with Cortex A due to __get_MSP usage.

cmain IAR: add mbed main

c19defe

This fixes #4602 issue, mbed_main should be invoked right before the real main

RTX5: uVisor: Defer to uVisor for SVCall priority

6bf7a68

Only set the SVCall priority if uVisor is not present. If uVisor is present, keep using whatever priorities it has already set up.

RTX5: uVisor: Extend thread control block with context

ab74f77

OsEventObserver objects expect a context to be maintained per thread on their behalf. Add this context to the thread control block and extend the thread creation functions with the ability to supply a context.

RTX5: uVisor: Use OsEventObserver

659fb92

uVisor: Import v0.30.0

dbd10f2

Reintroduce core_cmSecureAccess.h lost during CMSIS update

31aeca1

Update include paths to match updated CMSIS

d605b44

bulislaw force-pushed the feature_cortex_a branch from 8c11dfa to d605b44 Compare October 13, 2017 17:05

TomoYamanaka mentioned this pull request Oct 17, 2017

Build error occurs by using branch that supports CMSIS5/RTX5 for Cortex-A #4806

Closed

bulislaw closed this Oct 18, 2017

bulislaw deleted the feature_cortex_a branch October 18, 2017 16:31

sg- removed do not merge needs: work labels Oct 18, 2017

bulislaw mentioned this pull request Oct 18, 2017

Update CMSIS/RTX with Cortex-A support #5342

Merged

4 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update CMSIS/RTX with Cortex-A support #5312

Update CMSIS/RTX with Cortex-A support #5312

bulislaw commented Oct 12, 2017

bulislaw commented Oct 12, 2017

pan- Oct 12, 2017

bulislaw Oct 13, 2017

pan- commented Oct 12, 2017

bulislaw commented Oct 12, 2017

adbridge commented Oct 16, 2017

deepikabhavnani commented Oct 16, 2017

bulislaw commented Oct 16, 2017

TomoYamanaka commented Oct 17, 2017

bulislaw commented Oct 17, 2017

bulislaw commented Oct 17, 2017

mbed-ci commented Oct 17, 2017

mbed-ci commented Oct 17, 2017

bulislaw commented Oct 18, 2017

bulislaw commented Oct 18, 2017

mbed-ci commented Oct 18, 2017

studavekar commented Oct 18, 2017

Update CMSIS/RTX with Cortex-A support #5312

Update CMSIS/RTX with Cortex-A support #5312

Conversation

bulislaw commented Oct 12, 2017

Description

Status

ToDo

bulislaw commented Oct 12, 2017

pan- Oct 12, 2017

Choose a reason for hiding this comment

bulislaw Oct 13, 2017

Choose a reason for hiding this comment

pan- commented Oct 12, 2017

bulislaw commented Oct 12, 2017

adbridge commented Oct 16, 2017

deepikabhavnani commented Oct 16, 2017

bulislaw commented Oct 16, 2017

TomoYamanaka commented Oct 17, 2017

bulislaw commented Oct 17, 2017

bulislaw commented Oct 17, 2017

mbed-ci commented Oct 17, 2017

Build : ABORTED

mbed-ci commented Oct 17, 2017

Build : FAILURE

bulislaw commented Oct 18, 2017

bulislaw commented Oct 18, 2017

mbed-ci commented Oct 18, 2017

Build : FAILURE

studavekar commented Oct 18, 2017