Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add lorawan and nvstore examples for testing. #6304

Closed
wants to merge 1 commit into from

Conversation

adbridge
Copy link
Contributor

@adbridge adbridge commented Mar 8, 2018

Description

Add mbed-os-example-lorawan and mbed-os-example-nvstore to the examples list to be test compiled in the ci.

Pull request type

  • Fix
  • Refactor
  • New target
  • Feature
  • Breaking change

@adbridge
Copy link
Contributor Author

adbridge commented Mar 8, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 8, 2018

Build : FAILURE

Build number : 1391
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6304/

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 9, 2018

@AnttiKauppila @davidsaada Can you please look at the failures?

From the logs, some targets fail to build for these 2 additions. I can see that lorawan example in some cases have a problem with pin configuration.

for nvstore, some undefined needed symbols

@davidsaada
Copy link
Contributor

Fixed the NVStore issue.

@AnttiKauppila
Copy link

We indeed have some wrong PIN mappings. I am currently running our tests and when those are passing, I will provide a fix for this

@AnttiKauppila
Copy link

This should fix the PIN issues:
ARMmbed/mbed-os-example-lorawan@a7e7d76

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 9, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 9, 2018

Build : FAILURE

Build number : 1400
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6304/

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 9, 2018

@AnttiKauppila Fix helped, there are different failures now. Small devices have a problem and some even bigger ( k82f should have enough, might be a problem with linker script there?)

@AnttiKauppila
Copy link

I have provided another fixes by disabling example app in devices not supporting LoRa.

@AnttiKauppila
Copy link

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 11, 2018

Build : FAILURE

Build number : 1410
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6304/

@AnttiKauppila
Copy link

There is still one issue and it cannot be fixed by our application.
Our radios (Sx1272 and 1276) are using PinMode.PullUp enumeration and in target MIMXRT1050_EVK it is not available. I checked PinNames.h for this target and there are 3 different PullUps available: PullUp_47K, PullUp_100K and PullUp_22K.

I think this is an issue in the PinMode enumeration in "mbed-os/targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_MIMXRT1050/TARGET_EVK/PinNames.h", because for example DigitalIn.h documents this usage:
/** Set the input pin mode
*
* @param pull PullUp, PullDown, PullNone, OpenDrain
*/
void mode(PinMode pull);

@0xc0170, @adbridge Do you know who is responsible of this target?

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 12, 2018

I'll check that failure, and can propose a fix.

@cmonr
Copy link
Contributor

cmonr commented Mar 12, 2018

PR is now in master! Rebase needed to pull it in.

@cmonr
Copy link
Contributor

cmonr commented Mar 15, 2018

Closing since duplicate has now been merged and RC2 is now a thing.

@cmonr cmonr closed this Mar 15, 2018
@cmonr cmonr removed the needs: CI label Mar 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants