-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lorawan and nvstore examples for testing. #6304
Conversation
/morph build |
Build : FAILUREBuild number : 1391 |
@AnttiKauppila @davidsaada Can you please look at the failures? From the logs, some targets fail to build for these 2 additions. I can see that lorawan example in some cases have a problem with pin configuration. for nvstore, some undefined needed symbols |
Fixed the NVStore issue. |
We indeed have some wrong PIN mappings. I am currently running our tests and when those are passing, I will provide a fix for this |
This should fix the PIN issues: |
/morph build |
Build : FAILUREBuild number : 1400 |
@AnttiKauppila Fix helped, there are different failures now. Small devices have a problem and some even bigger ( k82f should have enough, might be a problem with linker script there?) |
I have provided another fixes by disabling example app in devices not supporting LoRa. |
/morph build |
Build : FAILUREBuild number : 1410 |
There is still one issue and it cannot be fixed by our application. I think this is an issue in the PinMode enumeration in "mbed-os/targets/TARGET_NXP/TARGET_MCUXpresso_MCUS/TARGET_MIMXRT1050/TARGET_EVK/PinNames.h", because for example DigitalIn.h documents this usage: @0xc0170, @adbridge Do you know who is responsible of this target? |
I'll check that failure, and can propose a fix. |
PR is now in master! Rebase needed to pull it in. |
Closing since duplicate has now been merged and RC2 is now a thing. |
Description
Add mbed-os-example-lorawan and mbed-os-example-nvstore to the examples list to be test compiled in the ci.
Pull request type