Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added SerialWireOutput to mbed namespace #6427

Merged
merged 1 commit into from
Mar 23, 2018
Merged

Added SerialWireOutput to mbed namespace #6427

merged 1 commit into from
Mar 23, 2018

Conversation

AGlass0fMilk
Copy link
Member

@AGlass0fMilk AGlass0fMilk commented Mar 22, 2018

Description

Added the SerialWireOutput driver to the mbed namespace

See issue #6421

See why this is a good idea in #5679

Pull request type

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@marcuschangarm
Copy link
Contributor

Thank you for fixing this!

@cmonr cmonr requested review from 0xc0170 and kjbracey March 22, 2018 16:44
@cmonr
Copy link
Contributor

cmonr commented Mar 22, 2018

Cool. Looks reasonable.
@AGlass0fMilk Thanks for the issue references.

@cmonr
Copy link
Contributor

cmonr commented Mar 22, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Mar 22, 2018

Build : SUCCESS

Build number : 1527
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6427/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Mar 22, 2018

@mbed-ci
Copy link

mbed-ci commented Mar 23, 2018

@kjbracey
Copy link
Contributor

This would be a breaking change for anyone using it who hadn't included "mbed.h" to get their compulsory using namespace mbed. I'm fine with that, but think it makes it a 5.9 thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants