LPC4088: Fix hardfault occuring after power-cycle #6598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the description, useful info - could you make it also part of the commit message ? |
Since revision 5499db1 (mbed-os-5.6.0) a hardfault occurs after a power-cycle. It doesn't occur after a reset when the application has been downloaded using drag-and-drop or via debugger. This is probably the reason why this problem isn't detected when testing new mbed releases. The hardfault occured in hal_sleep(). Adding a __NOP after __WFI solves the problem although I don't fully understand why. - Revision ca661f9 is the last revision where the problem doesn't occur. - The problem doesn't occur when compiling with GCC instead of ARM compiler - This issue describes a similar, but not identical problem and led me to test adding a __NOP: ARMmbed#5065
embeddedartists
force-pushed
the
lpc4088_hardfault_fix
branch
from
49f5ad1
to
01d06a9
Compare
|
@0xc0170 I have updated the commit message |
0xc0170
approved these changes
Apr 11, 2018
|
/morph build |
Build : SUCCESSBuild number : 1744 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1378 |
Test : SUCCESSBuild number : 1547 |
|
/morph mbed2-build |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Since revision 5499db1 (mbed-os-5.6.0) a hardfault occurs after a power-cycle. It doesn't occur after a reset when the application has been downloaded using drag-and-drop or via debugger. This is probably the reason why this problem isn't detected when testing new mbed releases.
The hardfault occured in hal_sleep(). Adding a __NOP after __WFI solves the problem although I don't fully understand why.
Pull request type
[ X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change