Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix MCUXpresso LPC I2C driver #6647

Merged
merged 2 commits into from
Apr 17, 2018
Merged

Fix MCUXpresso LPC I2C driver #6647

merged 2 commits into from
Apr 17, 2018

Conversation

mmahadevan108
Copy link
Contributor

Description

These failures were seen when running the ci-shield tests. All I2C tests pass after these patches.

[X] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

@mmahadevan108
MCUXpresso: Fix SDK LPC driver
69a950c 
Poll the Pending bit after START and STOP operations to ensure
operation completion.

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@mmahadevan108
MCUXpresso: Fix LPC I2C driver for byte operations
6e9f99c 
The ci-shield tests that manually generate the START, STOP
by calling the HAL functions were failing. The byte operation
HAL functions cannot use the MCUXpresso SDK driver API's.

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@mmahadevan108
Copy link
Contributor Author

cc @maclobdell @0xc0170

@cmonr
Copy link
Contributor

cmonr commented Apr 17, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Apr 17, 2018

Build : SUCCESS

Build number : 1762
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/6647/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Apr 17, 2018

Exporter Build : SUCCESS

Build number : 1399
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/6647/

@mbed-ci
Copy link

mbed-ci commented Apr 17, 2018

Test : SUCCESS

Build number : 1571
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/6647/1571

@maclobdell
Copy link
Contributor

I just tested with the CI Test Shield also and can confirm I2C is passing on LPC54628. Thanks Mahesh!

| LPC546XX-ARM | LPC546XX      | tests-api-i2c               | I2C -  EEProm 2nd WR 10  Bytes                                         | 1      | 0      | OK     | 0.06               |
| LPC546XX-ARM | LPC546XX      | tests-api-i2c               | I2C -  EEProm 2nd WR 100 Bytes                                         | 1      | 0      | OK     | 0.06               |
| LPC546XX-ARM | LPC546XX      | tests-api-i2c               | I2C -  EEProm 2nd WR 2 Bytes                                           | 1      | 0      | OK     | 0.05               |
| LPC546XX-ARM | LPC546XX      | tests-api-i2c               | I2C -  EEProm 2nd WR Single Byte                                       | 1      | 0      | OK     | 0.06               |
| LPC546XX-ARM | LPC546XX      | tests-api-i2c               | I2C -  EEProm WR 10  Bytes                                             | 1      | 0      | OK     | 0.07               |
| LPC546XX-ARM | LPC546XX      | tests-api-i2c               | I2C -  EEProm WR 100 Bytes                                             | 1      | 0      | OK     | 0.05               |
| LPC546XX-ARM | LPC546XX      | tests-api-i2c               | I2C -  EEProm WR 2 Bytes                                               | 1      | 0      | OK     | 0.06               |
| LPC546XX-ARM | LPC546XX      | tests-api-i2c               | I2C -  EEProm WR Single Byte                                           | 1      | 0      | OK     | 0.06               |
| LPC546XX-ARM | LPC546XX      | tests-api-i2c               | I2C -  Instantiation of I2C Object                                     | 1      | 0      | OK     | 0.07               |
| LPC546XX-ARM | LPC546XX      | tests-api-i2c               | I2C -  LM75B Temperature Read                                          | 1      | 0      | OK     | 0.06

@cmonr cmonr merged commit 1cc78f8 into ARMmbed:master Apr 17, 2018
@mmahadevan108 mmahadevan108 deleted the Fix_LPC54xxx_I2C branch April 19, 2018 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

Assignees
No one assigned
Labels
release-version: 5.8.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmahadevan108 @cmonr @mbed-ci @maclobdell @0xc0170