Modifying echo test to be driven more from the device. #6718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the echo test followed a flow like the following: -STEP- -HOST PC- -DEVICE- 0 send _sync 1 echo back _sync 2 send echo_count 3 echo back echo_count 4 send first echo packet 5 echo back echo packet (repeat echo steps) However, as noted by issue ARMmbed#6659, this test would somtimes fail between steps 4 and 5. To ensure each KV pair makes to the correct destination, we usually write the KV back. Step 4 does not wait for this to happen and starts sending echo packets. So the device is acting as the "echo server". This change makes the host PC the "echo server". The idea being that the device will be slower and the host pc should always be able to keep up with it, not the other way around.
0xc0170
approved these changes
Apr 24, 2018
|
/morph build |
Build : SUCCESSBuild number : 1832 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 1476 |
Test : SUCCESSBuild number : 1638 |
kjbracey
approved these changes
Apr 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the echo test followed a flow like the following:
However, as noted by issue #6659, this test would somtimes fail between
steps 4 and 5. To ensure each KV pair makes it to the correct destination,
we usually write the KV back. Step 4 does not wait for this to happen
and starts sending echo packets. So the device is acting as the "echo
server".
This change makes the host PC the "echo server". The idea being that the
device will be slower and the host pc should always be able to keep up
with it, not the other way around.
Pull request type
cc @cmonr