Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mbed-coap to version 4.5.0 #7320

Merged
merged 1 commit into from
Jun 27, 2018
Merged

Conversation

anttiylitokola
Copy link
Contributor

Description

Fix error: IIOTCLT-2769 - mbed-coap: extra response received after registration

Added own flag to enable blockwise support, without setting default blockwise
payload size. This allows to receive blockwise messages while still sending
without blockwise.

Fix CoAP request blockwise response handling
When request is sent, response can have blockwise option set. All requests must
be stored to the linked list.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change

Fix error:  IIOTCLT-2769 - mbed-coap: extra response received after registration

Added own flag to enable blockwise support, without setting default blockwise
payload size. This allows to receive blockwise messages while still sending
without blockwise.

Fix CoAP request blockwise response handling
When request is sent, response can have blockwise option set. All requests must
be stored to the linked list.
@anttiylitokola
Copy link
Contributor Author

@yogpan01, please review

@yogpan01
Copy link
Contributor

Looks ok, approved. This commit is required also by Thread for their inter-interoperability testing.
FYI @terhei @artokin.

@0xc0170
Copy link
Contributor

0xc0170 commented Jun 26, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Jun 26, 2018

Build : SUCCESS

Build number : 2448
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7320/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Jun 26, 2018

@mbed-ci
Copy link

mbed-ci commented Jun 26, 2018

@cmonr
Copy link
Contributor

cmonr commented Jun 27, 2018

Relaunching since this appears to have been a Jenkins Node failure.

/morph export-build

@cmonr
Copy link
Contributor

cmonr commented Jun 27, 2018

/morph export-build

@mbed-ci
Copy link

mbed-ci commented Jun 27, 2018

@cmonr cmonr merged commit d3641fd into ARMmbed:master Jun 27, 2018
@adbridge
Copy link
Contributor

adbridge commented Jul 4, 2018

@anttiylitokola Out of curiosity if this is just a fix release why has the coap minor release version gone up rather than just the patch version? Technically we should not be taking minor releases of any other component into our patch releases. We need to get more consistent across modules with semantic versioning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants