New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mbed-coap to version 4.5.0 #7320

Merged
merged 1 commit into from Jun 27, 2018

Conversation

Projects
None yet
6 participants
@anttiylitokola
Contributor

anttiylitokola commented Jun 25, 2018

Description

Fix error: IIOTCLT-2769 - mbed-coap: extra response received after registration

Added own flag to enable blockwise support, without setting default blockwise
payload size. This allows to receive blockwise messages while still sending
without blockwise.

Fix CoAP request blockwise response handling
When request is sent, response can have blockwise option set. All requests must
be stored to the linked list.

Pull request type

[x] Fix
[ ] Refactor
[ ] New target
[ ] Feature
[ ] Breaking change
Update mbed-coap to version 4.5.0
Fix error:  IIOTCLT-2769 - mbed-coap: extra response received after registration

Added own flag to enable blockwise support, without setting default blockwise
payload size. This allows to receive blockwise messages while still sending
without blockwise.

Fix CoAP request blockwise response handling
When request is sent, response can have blockwise option set. All requests must
be stored to the linked list.
@anttiylitokola

This comment has been minimized.

Contributor

anttiylitokola commented Jun 25, 2018

@yogpan01, please review

@cmonr cmonr requested a review from yogpan01 Jun 25, 2018

@cmonr cmonr added the needs: review label Jun 25, 2018

@yogpan01

This comment has been minimized.

Contributor

yogpan01 commented Jun 26, 2018

Looks ok, approved. This commit is required also by Thread for their inter-interoperability testing.
FYI @terhei @artokin.

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Jun 26, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Jun 26, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Jun 26, 2018

Build : SUCCESS

Build number : 2448
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7320/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 27, 2018

Relaunching since this appears to have been a Jenkins Node failure.

/morph export-build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Jun 27, 2018

/morph export-build

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Jun 27, 2018

@cmonr cmonr merged commit d3641fd into ARMmbed:master Jun 27, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 927 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8974 cycles (-621 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9964B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
@adbridge

This comment has been minimized.

Contributor

adbridge commented Jul 4, 2018

@anttiylitokola Out of curiosity if this is just a fix release why has the coap minor release version gone up rather than just the patch version? Technically we should not be taking minor releases of any other component into our patch releases. We need to get more consistent across modules with semantic versioning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment