-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tools: Scan for "components" #7644
Conversation
Great, naming TBD but otherwise looks great 👍 |
@sg-, when you say naming TBD, are you referring to the scan rule? the config variables? both? |
both |
I think we need a strong documentation to match these changes. It'll confuse people, we should explain what's the difference between feature and a component. |
I'm unsure is this really needed. (Sorry, not public links)
If I could vote on this design, I would have gone to direction where we use more generic ways of flagging buildable stuff. For example all |
Luckily, your info is out of date:
If you look at all that I changed to add another one, it's pretty generic.
This is currently the case.
All scan rules can be nested on current |
4e183a8
to
a4aa485
Compare
@theotherjimmy I assume components refer to "on board" components versus "on die" components? |
@theotherjimmy also are component sources intended to exist within mbed-os or externally? |
@SeppoTakalo @loverdeg-ep If it helps, this is an example use case of why having this descriptor would help: #7774 |
@sg- @bulislaw @theotherjimmy Any more thoughts on the naming, since it this PR has been open for a while? Imo, "Components" seems a bit too generic, but I also don't have any better suggestions. @theotherjimmy Be advised this still needs to pass Travis. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. That needs to be documented in Handbook including some guidance what belongs in TARGET, FEATURE, COMPONENT and TOOLCHAIN even if you think it's obvious.
@theotherjimmy could you please respond to @cmonr comments ? |
Would the build system support using this scan rule to have a "target support package" pull a sensor driver, for example, from an external repository? My thinking,
Probably wandering a little too far down a side road, but this is what I want as a user. |
@theotherjimmy What is the status ? There are few dependent PR targeting also 5.10 release. Documentation PR? |
Making a note here that this is a dependency for #7774, which will need some TLC to get in. |
5ae4e6c
to
e695a34
Compare
/morph build |
Build : FAILUREBuild number : 2935 |
Wow. License issue. /morph build |
Build : ABORTEDBuild number : 2936 |
Looks like something's happened to the ARM compiler license server. |
/morph build |
Build : SUCCESSBuild number : 2937 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2555 |
Test : SUCCESSBuild number : 2686 |
Description
Requested by @sg-
Creates the
COMPONENT_
scanning rule to match thetarget.components
,target.components_add
andtargets.components_remove
configuration values.@sg- to provide justification
Pull request type