Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Error Decoding URL to error report #7662

Merged
merged 1 commit into from
Aug 31, 2018
Merged

Conversation

SenRamakri
Copy link
Contributor

Description

Adding Error Decoding URL to error report.

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[x] Feature
[ ] Breaking change


"error-decode-http-url-str": {
"help": "HTTP URL string for ARM Mbed-OS Error Decode microsite",
"value": "\"\\nFor more info, goto: https://armmbed.github.io/mbedos-error/?error=0x%08X\""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would suggest either adding a space in goto or replacing it with visit.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"visit" sounds better, let me make that change.

@cmonr
Copy link
Contributor

cmonr commented Aug 3, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 3, 2018

Build : FAILURE

Build number : 2731
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7662/

@cmonr
Copy link
Contributor

cmonr commented Aug 3, 2018

I really hope this isn't what I think it is.

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 3, 2018

Build : FAILURE

Build number : 2732
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7662/

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 6, 2018

One more, if still removes, we need to check assembly IAR

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 6, 2018

Build : FAILURE

Build number : 2740
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7662/

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 6, 2018

@theotherjimmy can you review these failures? Is it related to the IAR update that we already marked as questionable (specifically this PR #7061)

@theotherjimmy
Copy link
Contributor

@TTornblom Could you take a look at this failure. I'm afraid that @0xc0170 is correct: it looks related to adding configuration to assembly.

@@ -389,7 +389,7 @@ static void print_error_report(mbed_error_ctx *ctx, const char *error_msg)
threads = (osRtxThread_t *)&osRtxInfo.thread.idle;
print_threads_info(threads);
#endif

mbed_error_printf( MBED_CONF_PLATFORM_ERROR_DECODE_HTTP_URL_STR, ctx->error_status );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

astyle travis - please check it , this line is shown there


"error-decode-http-url-str": {
"help": "HTTP URL string for ARM Mbed-OS Error Decode microsite",
"value": "\"\\nFor more info, visit: https://armmbed.github.io/mbedos-error/?error=0x%08X\""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any examples how this works, what error codes we can try to test?

@TTornblom
Copy link
Contributor

Any test case I can use to check this?

@BlackstoneEngineering
Copy link
Contributor

@TTornblom
Copy link
Contributor

What I meant was how can I provoke the IAR related failures.

@cmonr
Copy link
Contributor

cmonr commented Aug 18, 2018

@TTornblom You should be able to use any failing case in this repo. The logs all contain the commands that were used to build them.

A random example: http://mbed-os.s3-eu-west-1.amazonaws.com/builds/7662/FAIL/K64F/IAR/0a8fe4f0d8c3da350bd5fda9bfee7bb29ef50a09_build_log_K64F_IAR.txt

For reference, you can actually checkout PR commits from a repo.
Something like the following should work:

git clone https://github.com/ARMmbed/mbed-os
cd mbed-os
git fetch origin refs/pull/7662/head:pr7662
git checkout pr7662

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 22, 2018

@TTornblom Any progress with reproducing the failure?

@TTornblom
Copy link
Contributor

Sorry no.

We have been unable to reproduce this in house, and the version used (7.80) is no longer maintained so we can't, with reasonable effort, produce any debug binaries.

For the issues where iasmarm fails with error -11, which I assume is a segmentation fault, can a core dump be collected for analysis?

@cmonr
Copy link
Contributor

cmonr commented Aug 22, 2018

@OPpuolitaival @ARMmbed/mbed-os-test Is ti possible to get a core dump of the problem?

@cmonr
Copy link
Contributor

cmonr commented Aug 22, 2018

Going to try a rebuild to see if our current configuration dumps the segfault.

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 22, 2018

Build : FAILURE

Build number : 2872
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7662/

@0xc0170
Copy link
Contributor

0xc0170 commented Aug 30, 2018

I rebased, and compiled it with ARM, IAR and GCC ARM, seems to be working but functional test is still needed

@cmonr
Copy link
Contributor

cmonr commented Aug 31, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Aug 31, 2018

Build : SUCCESS

Build number : 2969
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7662/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Aug 31, 2018

@mbed-ci
Copy link

mbed-ci commented Aug 31, 2018

@cmonr
Copy link
Contributor

cmonr commented Aug 31, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Aug 31, 2018

@cmonr cmonr merged commit a849fa4 into ARMmbed:master Aug 31, 2018
@0xc0170 0xc0170 removed the needs: CI label Aug 31, 2018
@cmonr cmonr removed the risk: A label Sep 2, 2018
@mattbrown015
Copy link
Contributor

I believe the URL is generating a warning:

Compile [ 54.4%]: mbed_error.c
[Warning] mbed_error.c@392,23: unknown escape sequence: '/'

Could it be because I'm building on Windows (with GCC)?

Not the end of the world I know but I'd rather it didn't! :-)

@cmonr
Copy link
Contributor

cmonr commented Sep 5, 2018

@mattbrown015 It's completely possible. Would you mind opening an issue so that we can track it?

@kegilbert
Copy link
Contributor

kegilbert commented Sep 5, 2018

@mattbrown015 thanks for pointing this out! I see the same warning in Linux using GCC_ARM.

@cmonr Do you need the // between 'https:/' and '/armmbed' in the below string?
"\"\\nFor more info, visit: https:/\\/armmbed.github.io/mbedos-error/?error=0x%08X\""
https://github.com/ARMmbed/mbed-os/blob/master/platform/mbed_lib.json#L75

The printing mechanics in the error handler are a bit different from printf due to the context, but the above string doesn't seem to actually be formatted correctly (you'd get an invalid URL from printf at least).

@kegilbert kegilbert mentioned this pull request Sep 7, 2018
cmonr pushed a commit that referenced this pull request Sep 18, 2018
IAR: Fix for #7662, only massage the error decode URL for the IAR .xcl
cmonr pushed a commit that referenced this pull request Sep 18, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants