-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Error Decoding URL to error report #7662
Conversation
platform/mbed_lib.json
Outdated
|
||
"error-decode-http-url-str": { | ||
"help": "HTTP URL string for ARM Mbed-OS Error Decode microsite", | ||
"value": "\"\\nFor more info, goto: https://armmbed.github.io/mbedos-error/?error=0x%08X\"" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would suggest either adding a space in goto
or replacing it with visit
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"visit" sounds better, let me make that change.
/morph build |
Build : FAILUREBuild number : 2731 |
I really hope this isn't what I think it is. /morph build |
Build : FAILUREBuild number : 2732 |
One more, if still removes, we need to check assembly IAR /morph build |
Build : FAILUREBuild number : 2740 |
@theotherjimmy can you review these failures? Is it related to the IAR update that we already marked as questionable (specifically this PR #7061) |
@TTornblom Could you take a look at this failure. I'm afraid that @0xc0170 is correct: it looks related to adding configuration to assembly. |
platform/mbed_error.c
Outdated
@@ -389,7 +389,7 @@ static void print_error_report(mbed_error_ctx *ctx, const char *error_msg) | |||
threads = (osRtxThread_t *)&osRtxInfo.thread.idle; | |||
print_threads_info(threads); | |||
#endif | |||
|
|||
mbed_error_printf( MBED_CONF_PLATFORM_ERROR_DECODE_HTTP_URL_STR, ctx->error_status ); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
astyle travis - please check it , this line is shown there
platform/mbed_lib.json
Outdated
|
||
"error-decode-http-url-str": { | ||
"help": "HTTP URL string for ARM Mbed-OS Error Decode microsite", | ||
"value": "\"\\nFor more info, visit: https://armmbed.github.io/mbedos-error/?error=0x%08X\"" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any examples how this works, what error codes we can try to test?
Any test case I can use to check this? |
What I meant was how can I provoke the IAR related failures. |
@TTornblom You should be able to use any failing case in this repo. The logs all contain the commands that were used to build them. A random example: http://mbed-os.s3-eu-west-1.amazonaws.com/builds/7662/FAIL/K64F/IAR/0a8fe4f0d8c3da350bd5fda9bfee7bb29ef50a09_build_log_K64F_IAR.txt For reference, you can actually checkout PR commits from a repo.
|
@TTornblom Any progress with reproducing the failure? |
Sorry no. We have been unable to reproduce this in house, and the version used (7.80) is no longer maintained so we can't, with reasonable effort, produce any debug binaries. For the issues where iasmarm fails with error -11, which I assume is a segmentation fault, can a core dump be collected for analysis? |
@OPpuolitaival @ARMmbed/mbed-os-test Is ti possible to get a core dump of the problem? |
Going to try a rebuild to see if our current configuration dumps the segfault. /morph build |
Build : FAILUREBuild number : 2872 |
I rebased, and compiled it with ARM, IAR and GCC ARM, seems to be working but functional test is still needed |
/morph build |
Build : SUCCESSBuild number : 2969 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2584 |
Test : FAILUREBuild number : 2722 |
/morph test |
Test : SUCCESSBuild number : 2727 |
I believe the URL is generating a warning:
Could it be because I'm building on Windows (with GCC)? Not the end of the world I know but I'd rather it didn't! :-) |
@mattbrown015 It's completely possible. Would you mind opening an issue so that we can track it? |
@mattbrown015 thanks for pointing this out! I see the same warning in Linux using GCC_ARM. @cmonr Do you need the The printing mechanics in the error handler are a bit different from printf due to the context, but the above string doesn't seem to actually be formatted correctly (you'd get an invalid URL from printf at least). |
IAR: Fix for #7662, only massage the error decode URL for the IAR .xcl
Description
Adding Error Decoding URL to error report.
Pull request type