New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Error Decoding URL to error report #7662

Merged
merged 1 commit into from Aug 31, 2018

Conversation

Projects
None yet
9 participants
@SenRamakri
Contributor

SenRamakri commented Jul 31, 2018

Description

Adding Error Decoding URL to error report.

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[x] Feature
[ ] Breaking change

@SenRamakri SenRamakri force-pushed the SenRamakri:sen_ErrorUrl branch from 90f4965 to 0afc7e3 Jul 31, 2018


"error-decode-http-url-str": {
"help": "HTTP URL string for ARM Mbed-OS Error Decode microsite",
"value": "\"\\nFor more info, goto: https://armmbed.github.io/mbedos-error/?error=0x%08X\""

This comment has been minimized.

@cmonr

cmonr Jul 31, 2018

Contributor

I would suggest either adding a space in goto or replacing it with visit.

This comment has been minimized.

@SenRamakri

SenRamakri Jul 31, 2018

Contributor

"visit" sounds better, let me make that change.

@cmonr

cmonr approved these changes Jul 31, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 3, 2018

/morph build

@cmonr cmonr added needs: CI and removed needs: review labels Aug 3, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 3, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 3, 2018

I really hope this isn't what I think it is.

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 3, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 6, 2018

One more, if still removes, we need to check assembly IAR

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 6, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 6, 2018

@theotherjimmy can you review these failures? Is it related to the IAR update that we already marked as questionable (specifically this PR #7061)

@theotherjimmy

This comment has been minimized.

Contributor

theotherjimmy commented Aug 6, 2018

@TTornblom Could you take a look at this failure. I'm afraid that @0xc0170 is correct: it looks related to adding configuration to assembly.

@@ -389,7 +389,7 @@ static void print_error_report(mbed_error_ctx *ctx, const char *error_msg)
threads = (osRtxThread_t *)&osRtxInfo.thread.idle;
print_threads_info(threads);
#endif

mbed_error_printf( MBED_CONF_PLATFORM_ERROR_DECODE_HTTP_URL_STR, ctx->error_status );

This comment has been minimized.

@0xc0170

0xc0170 Aug 7, 2018

Member

astyle travis - please check it , this line is shown there


"error-decode-http-url-str": {
"help": "HTTP URL string for ARM Mbed-OS Error Decode microsite",
"value": "\"\\nFor more info, visit: https://armmbed.github.io/mbedos-error/?error=0x%08X\""

This comment has been minimized.

@0xc0170

0xc0170 Aug 7, 2018

Member

Any examples how this works, what error codes we can try to test?

@cmonr cmonr added needs: work and removed needs: CI labels Aug 7, 2018

@TTornblom

This comment has been minimized.

Contributor

TTornblom commented Aug 14, 2018

Any test case I can use to check this?

@BlackstoneEngineering

This comment has been minimized.

@TTornblom

This comment has been minimized.

Contributor

TTornblom commented Aug 15, 2018

What I meant was how can I provoke the IAR related failures.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 18, 2018

@TTornblom You should be able to use any failing case in this repo. The logs all contain the commands that were used to build them.

A random example: http://mbed-os.s3-eu-west-1.amazonaws.com/builds/7662/FAIL/K64F/IAR/0a8fe4f0d8c3da350bd5fda9bfee7bb29ef50a09_build_log_K64F_IAR.txt

For reference, you can actually checkout PR commits from a repo.
Something like the following should work:

git clone https://github.com/ARMmbed/mbed-os
cd mbed-os
git fetch origin refs/pull/7662/head:pr7662
git checkout pr7662
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 22, 2018

@TTornblom Any progress with reproducing the failure?

@TTornblom

This comment has been minimized.

Contributor

TTornblom commented Aug 22, 2018

Sorry no.

We have been unable to reproduce this in house, and the version used (7.80) is no longer maintained so we can't, with reasonable effort, produce any debug binaries.

For the issues where iasmarm fails with error -11, which I assume is a segmentation fault, can a core dump be collected for analysis?

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 22, 2018

@OPpuolitaival @ARMmbed/mbed-os-test Is ti possible to get a core dump of the problem?

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 22, 2018

Going to try a rebuild to see if our current configuration dumps the segfault.

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 22, 2018

@0xc0170 0xc0170 force-pushed the SenRamakri:sen_ErrorUrl branch from fdac62d to e84e56b Aug 30, 2018

@0xc0170 0xc0170 added needs: review and removed needs: work labels Aug 30, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 31, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 31, 2018

Build : SUCCESS

Build number : 2969
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7662/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 31, 2018

/morph test

@mbed-ci

This comment has been minimized.

@cmonr cmonr merged commit a849fa4 into ARMmbed:master Aug 31, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
travis-ci/astyle Passed, 558 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9905 cycles (+49 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the needs: CI label Aug 31, 2018

@cmonr cmonr removed the risk: A label Sep 2, 2018

@mattbrown015

This comment has been minimized.

Contributor

mattbrown015 commented Sep 3, 2018

I believe the URL is generating a warning:

Compile [ 54.4%]: mbed_error.c
[Warning] mbed_error.c@392,23: unknown escape sequence: '/'

Could it be because I'm building on Windows (with GCC)?

Not the end of the world I know but I'd rather it didn't! :-)

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 5, 2018

@mattbrown015 It's completely possible. Would you mind opening an issue so that we can track it?

@kegilbert

This comment has been minimized.

Contributor

kegilbert commented Sep 5, 2018

@mattbrown015 thanks for pointing this out! I see the same warning in Linux using GCC_ARM.

@cmonr Do you need the // between 'https:/' and '/armmbed' in the below string?
"\"\\nFor more info, visit: https:/\\/armmbed.github.io/mbedos-error/?error=0x%08X\""
https://github.com/ARMmbed/mbed-os/blob/master/platform/mbed_lib.json#L75

The printing mechanics in the error handler are a bit different from printf due to the context, but the above string doesn't seem to actually be formatted correctly (you'd get an invalid URL from printf at least).

@kegilbert kegilbert referenced this pull request Sep 7, 2018

Closed

Fix error decode link #8040

cmonr added a commit to cmonr/mbed-os that referenced this pull request Sep 17, 2018

cmonr added a commit that referenced this pull request Sep 18, 2018

Merge pull request #8017 from TTornblom/master
IAR: Fix for #7662, only massage the error decode URL for the IAR .xcl

cmonr added a commit that referenced this pull request Sep 18, 2018

cmonr added a commit that referenced this pull request Sep 18, 2018

cmonr added a commit that referenced this pull request Sep 18, 2018

cmonr added a commit that referenced this pull request Sep 18, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment