New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IAR: Fix for #7662, only massage the error decode URL for the IAR .xcl #8017

Merged
merged 1 commit into from Sep 18, 2018

Conversation

Projects
None yet
5 participants
@TTornblom
Contributor

TTornblom commented Sep 6, 2018

Description

tools/toolchains/iar.py:
Replace "//" sequence in get_compile_options() for_asm when generating the .xcl file.
This eliminates the need to escape this sequence in the .json files, which upsets other toolchains.

Tested with IAR and GCC_ARM toolchains with the mbed-os-example-blinky example.

platform/mbed_lib.json:
Removed the "\" escape sequence

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-tools Sep 6, 2018

@0xc0170 0xc0170 requested a review from kjbracey-arm Sep 17, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 17, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 17, 2018

Build : SUCCESS

Build number : 3087
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8017/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 17, 2018

/morph mbed2-build

1 similar comment
@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 17, 2018

/morph mbed2-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 17, 2018

Will rerun mbed2-build test shortly. Meant to run a different PR.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 18, 2018

/morph mbed2-build

@cmonr cmonr merged commit 3da606e into ARMmbed:master Sep 18, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
travis-ci/astyle Passed, 598 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10321 cycles (+1094 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment