New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Gemalto Cinterion support for ELS61 and BGS2 #7677

Merged
merged 4 commits into from Aug 29, 2018

Conversation

Projects
None yet
6 participants
@AriParkkila
Contributor

AriParkkila commented Aug 2, 2018

Description

AT command support for the Gemalto Cinterion cellular modules:

  • LWIP supported in PPP mode
  • UDP sockets supported in AT mode

Depends on PR #7860.

Pull request type

[ ] Fix
[ ] Refactor
[ ] New target
[X] Feature
[ ] Breaking change

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-wan Aug 2, 2018

@AriParkkila AriParkkila force-pushed the AriParkkila:cell-gemalto branch from 929c98c to b644d94 Aug 3, 2018

@AriParkkila

This comment has been minimized.

Contributor

AriParkkila commented Aug 13, 2018

return (reg_type == C_REG || reg_type == C_GREG || reg_type == C_EREG);
}

const char *GEMALTO_CINTERION_CellularNetwork::get_apn() const

This comment has been minimized.

@jarvte

jarvte Aug 13, 2018

Contributor

no need for this method as _apn is protected in inherited class

}

socket->created = true;
tr_info("Socket %d created (err %d)", socket->id, _at.get_last_error());

This comment has been minimized.

@jarvte

jarvte Aug 13, 2018

Contributor

Could be debug so that log is not polluted.

nsapi_size_or_error_t GEMALTO_CINTERION_CellularStack::socket_sendto_impl(CellularSocket *socket,
const SocketAddress &address, const void *data, nsapi_size_t size)
{
tr_info("Socket %d, sendto %s, len %d", socket->id, address.get_ip_address(), size);

This comment has been minimized.

@jarvte

jarvte Aug 13, 2018

Contributor

Could be debug so that log is not polluted.

_at.write_bytes((uint8_t *)data, accept_len);
_at.resp_stop();

tr_info("Socket %d sendto %s, %d bytes (err %d)", socket->id, address.get_ip_address(), accept_len, _at.get_last_error());

This comment has been minimized.

@jarvte

jarvte Aug 13, 2018

Contributor

Could be debug so that log is not polluted.

nsapi_size_or_error_t GEMALTO_CINTERION_CellularStack::socket_recvfrom_impl(CellularSocket *socket, SocketAddress *address,
void *buffer, nsapi_size_t size)
{
tr_info("Socket %d recvfrom %d bytes", socket->id, size);

This comment has been minimized.

@jarvte

jarvte Aug 13, 2018

Contributor

Could be debug so that log is not polluted.


_at.resp_stop();

tr_info("Socket %d, recvfrom %s, %d bytes (err %d)", socket->id, ip_address, len, _at.get_last_error());

This comment has been minimized.

@jarvte

jarvte Aug 13, 2018

Contributor

Could be debug so that log is not polluted.

@AriParkkila AriParkkila force-pushed the AriParkkila:cell-gemalto branch from b644d94 to adae5a1 Aug 14, 2018

@AriParkkila

This comment has been minimized.

Contributor

AriParkkila commented Aug 14, 2018

Removed redundant get_apn() and fixed tracing level to tr_debug. Also rebased with mbed-os/master.

@jarvte

jarvte approved these changes Aug 14, 2018

@AriParkkila AriParkkila force-pushed the AriParkkila:cell-gemalto branch from adae5a1 to a42d74f Aug 17, 2018

@AriParkkila AriParkkila changed the title from Cellular: Gemalto Cinterion support for ELS61 to Cellular: Gemalto Cinterion support for ELS61 and BGS2 Aug 17, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 22, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 22, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 23, 2018

Restarting the build, should be fine now (previous failure was known yesterday and was fixed)

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 23, 2018

Build : SUCCESS

Build number : 2881
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7677/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 23, 2018

Pausing Test CI until 5.9.6 PR is merged.
Will restart CI shortly after.

@cmonr cmonr added the risk: G label Aug 24, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 24, 2018

/morph test

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 24, 2018

/morph uvisor-test

1 similar comment
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 24, 2018

/morph uvisor-test

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 24, 2018

uvisor CI reports this error : GEMALTO_CINTERION_CellularStack.cpp@461,28: 'strtol' is not a member of 'std' please review

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Aug 24, 2018

@mbed-ci

This comment has been minimized.

@AriParkkila

This comment has been minimized.

Contributor

AriParkkila commented Aug 27, 2018

@0xc0170 added more comments and removed out-commented code. Also fixed network registration as that has changed in PR #7860, which must be merged first.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 27, 2018

@AriParkkila Were a couple of lines missed?

Normally GitHub will collapse review comments when the line disappears from the review.

@AriParkkila

This comment has been minimized.

Contributor

AriParkkila commented Aug 28, 2018

@cmonr for me, GitHub is a bit too clever in how it handles review comments, do you see something missing there... I'm guessing that due to this PR does not compile without PR #7860 that might mess up how GitHub shows review comments?

@AriParkkila AriParkkila force-pushed the AriParkkila:cell-gemalto branch from 620656a to 3c8acea Aug 28, 2018

@AriParkkila AriParkkila force-pushed the AriParkkila:cell-gemalto branch from 3c8acea to 90fe9de Aug 28, 2018

@AriParkkila

This comment has been minimized.

Contributor

AriParkkila commented Aug 28, 2018

Please trigger morph builds to see that this passes all tests.

@0xc0170 0xc0170 added the needs: CI label Aug 28, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Aug 28, 2018

/morph build

@cmonr cmonr added risk: G and removed risk: A labels Aug 28, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 28, 2018

Build : SUCCESS

Build number : 2943
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7677/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Aug 29, 2018

@0xc0170 0xc0170 merged commit 70439dd into ARMmbed:master Aug 29, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job was successful
Details
travis-ci/astyle Passed, 555 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9139 cycles (-1185 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@AriParkkila AriParkkila deleted the AriParkkila:cell-gemalto branch Sep 10, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment