New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

STM32 wrong MBED_ASSERT use #7775

Merged
merged 9 commits into from Aug 21, 2018

Conversation

Projects
None yet
7 participants
@jeromecoutant
Contributor

jeromecoutant commented Aug 13, 2018

Description

In all SetSysClock functions, when system clock configuration is failing, we go into :
MBED_ASSERT(1)
which will actually never assert...

Code is then replaced by the error macro

Thx @mattbrown015

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change

@cmonr cmonr added the needs: review label Aug 13, 2018

@cmonr cmonr self-requested a review Aug 13, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Aug 20, 2018

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 20, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Aug 20, 2018

Build : SUCCESS

Build number : 2842
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7775/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Aug 21, 2018

/morph uvisor-test

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Aug 21, 2018

CI passed, but only one review @0xc0170 does this need another review or is it ready for merge?

@0xc0170 0xc0170 requested a review from ARMmbed/team-st-mcd Aug 21, 2018

@LMESTM

LMESTM approved these changes Aug 21, 2018

@cmonr cmonr merged commit c167275 into ARMmbed:master Aug 21, 2018

14 checks passed

AWS-CI uVisor Build & Test Success
Details
ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 583 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9879 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 9960B
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

pan- pushed a commit to pan-/mbed that referenced this pull request Aug 22, 2018

@bcostm

This comment has been minimized.

Contributor

bcostm commented Aug 28, 2018

I don't know how we can send characters though UART if we have no clock... I think MBED_ASSERT(0) was a better solution.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Aug 28, 2018

I don't know how we can send characters though UART if we have no clock... I think MBED_ASSERT(0) was a better solution.

What is the difference? both print, so in the case of failures nothing is being reported for both or ?

@bcostm

This comment has been minimized.

Contributor

bcostm commented Aug 28, 2018

Yes you're right, even MBED_ASSERT(0) will do nothing as there is no clock at all running. Nothing can be done at this point I think...

@jeromecoutant jeromecoutant deleted the jeromecoutant:PR_ASSERT branch Sep 3, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment