STM32 wrong MBED_ASSERT use

[jeromecoutant]

Description

In all SetSysClock functions, when system clock configuration is failing, we go into :
MBED_ASSERT(1)
which will actually never assert...

Code is then replaced by the error macro

Thx @mattbrown015

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Feature
[ ] Breaking change

[0xc0170]

/morph build

[mbed-ci]

Build : SUCCESS

Build number : 2842
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7775/

Triggering tests

/morph test
/morph uvisor-test
/morph export-build
/morph mbed2-build

[mbed-ci]

Exporter Build : SUCCESS

Build number : 2470
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7775/

[mbed-ci]

Test : SUCCESS

Build number : 2594
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7775/2594

[NirSonnenschein]

/morph uvisor-test

[NirSonnenschein]

CI passed, but only one review @0xc0170 does this need another review or is it ready for merge?

[bcostm]

I don't know how we can send characters though UART if we have no clock... I think MBED_ASSERT(0) was a better solution.

[0xc0170]

I don't know how we can send characters though UART if we have no clock... I think MBED_ASSERT(0) was a better solution.

What is the difference? both print, so in the case of failures nothing is being reported for both or ?

[bcostm]

Yes you're right, even MBED_ASSERT(0) will do nothing as there is no clock at all running. Nothing can be done at this point I think...