Fix is_valid_erase function to use get_erase_size with address

[davidsaada]

Description

The base BlockDevice class includes the is_valid_erase function checking whether the address and size given to the erase API are valid. This function used to call the get_erase_size function without the address argument, but this was a bug, as it would have failed valid calls to erase. It now calls get_erase_size with the address argument.
Just to clarify - this will work also for classes that don't implement get_erase_size with the address parameter, as it defaults to the one that doesn't have the address in the base class.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

[offirko]

You check that 'size' is aligned with current 'addr' but a large 'size' might take you to a 'dest' address in a different sector with a different 'erase-size' than 'addr'.
Basically I think you need to verify that:
( (addr+size) % get_erase_size(addr+size-1) == 0 )

[davidsaada]

You are right about my code, but your solution is also problematic, as it only checks one sector. The right solution would be to iterate on the remaining sectors. Will fix that.

[davidsaada]

You are right about the problem in my code, but your solution probably won't work either (as both only cover one sector). Right solution is probably an iteration over the remaining of the sectors. I'll fix it.

[offirko]

@davidsaada - My thinking is that if the 'start' delete address is aligned to its sector, and the 'end' delete address is aligned to its own sector - then every sector in between them will be fully erased - so there's no need to iterate. What do you think?

[davidsaada]

You're right - better than iteration. Will fix.

[davidsaada]

Fixed. Please review.

[0xc0170]

/morph build

[mbed-ci]

Build : SUCCESS

Build number : 3166
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7953/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

[mbed-ci]

Exporter Build : SUCCESS

Build number : 2767
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/7953/

[mbed-ci]

Test : SUCCESS

Build number : 2974
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/7953/2974