Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrf_ble: Expose configuration of max characteristics and descriptors #7958

Merged
merged 1 commit into from
Oct 9, 2018

Conversation

andrewleech
Copy link
Contributor

Description

This PR simply exposes a couple of hard defined BLE limits in the config system.
These defines restrict the configuration of larger BLE projects and can't be worked around without changing this file in mbed-os.

This PR does not change the default behavior of these defines, just allows them to be changed by an end-user project.

  • BLE_TOTAL_CHARACTERISTICS
    Limits the maximum number of characteristics that can be configured on the BLE stack

  • BLE_TOTAL_DESCRIPTORS
    Limits the maximum number of descriptors that can be configured on the BLE stack

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 3, 2018

@ARMmbed/mbed-os-pan Please review

@cmonr
Copy link
Contributor

cmonr commented Sep 27, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 27, 2018

Build : SUCCESS

Build number : 3176
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7958/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 27, 2018

@mbed-ci
Copy link

mbed-ci commented Sep 27, 2018

@cmonr
Copy link
Contributor

cmonr commented Sep 27, 2018

Dang it. Sync failures with NRF51.

Will restart when able.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 2, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Oct 2, 2018

@NirSonnenschein
Copy link
Contributor

/morph build

3 similar comments
@NirSonnenschein
Copy link
Contributor

/morph build

@NirSonnenschein
Copy link
Contributor

/morph build

@cmonr
Copy link
Contributor

cmonr commented Oct 8, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 8, 2018

Build : SUCCESS

Build number : 3282
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7958/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 8, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 8, 2018

@cmonr
Copy link
Contributor

cmonr commented Oct 8, 2018

/morph mbed2-build

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants