New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrf_ble: Expose configuration of max characteristics and descriptors #7958

Merged
merged 1 commit into from Oct 9, 2018

Conversation

Projects
None yet
7 participants
@andrewleech
Contributor

andrewleech commented Sep 3, 2018

Description

This PR simply exposes a couple of hard defined BLE limits in the config system.
These defines restrict the configuration of larger BLE projects and can't be worked around without changing this file in mbed-os.

This PR does not change the default behavior of these defines, just allows them to be changed by an end-user project.

  • BLE_TOTAL_CHARACTERISTICS
    Limits the maximum number of characteristics that can be configured on the BLE stack

  • BLE_TOTAL_DESCRIPTORS
    Limits the maximum number of descriptors that can be configured on the BLE stack

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 3, 2018

@ARMmbed/mbed-os-pan Please review

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-pan Sep 6, 2018

@andrewleech andrewleech force-pushed the andrewleech:nrf_ble_configs branch from 11ac960 to 676f50a Sep 19, 2018

@pan-

pan- approved these changes Sep 24, 2018

@0xc0170 0xc0170 added needs: CI and removed needs: review labels Sep 24, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 27, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 27, 2018

Build : SUCCESS

Build number : 3176
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7958/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 27, 2018

Dang it. Sync failures with NRF51.

Will restart when able.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Oct 2, 2018

/morph test

@mbed-ci

This comment has been minimized.

@andrewleech andrewleech force-pushed the andrewleech:nrf_ble_configs branch from 676f50a to a6f33a1 Oct 3, 2018

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 3, 2018

/morph build

3 similar comments
@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 3, 2018

/morph build

@NirSonnenschein

This comment has been minimized.

Contributor

NirSonnenschein commented Oct 7, 2018

/morph build

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 8, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 8, 2018

Build : SUCCESS

Build number : 3282
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/7958/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 8, 2018

/morph mbed2-build

@0xc0170 0xc0170 merged commit 313073c into ARMmbed:master Oct 9, 2018

14 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 626 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10303 cycles (+91 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@0xc0170 0xc0170 removed the ready for merge label Oct 9, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment