STM32: Fix alignment of execute region to 8byte boundary #8013

deepikabhavnani · 2018-09-05T22:23:23Z

Description

Resolves #8004

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

JanneKiiskila · 2018-09-05T22:28:11Z

Nope, this is only fixing a very small subset of targets. It's no good, you must fix ALL of them.

deepikabhavnani · 2018-09-05T22:30:13Z

Nope, this is only fixing a very small subset of targets. It's no good, you must fix ALL of them.

Please share which targets are failing, we do not support ARMC6 for all v6/v7 targets.

deepikabhavnani · 2018-09-06T18:50:47Z

Fix is for all ST targets

jeromecoutant · 2018-09-07T07:15:17Z

Hi
We need to fix also icf IAR files and ld GCC files....

@ARMmbed/team-st-mcd

jeromecoutant · 2018-09-07T07:17:51Z

mbed-os/targets/TARGET_STM/TARGET_STM32L4/TARGET_STM32L496xG/device/TOOLCHAIN_IAR/stm32l496xx.icf

Line 10 in 48c149b

    
           define symbol __region_SRAM1_start__  = 0x200001AC; /* Aligned on 8 bytes (428 = 53 x 8) */

I like comment "428 = 53 x 8" ...

deepikabhavnani · 2018-09-12T22:07:09Z

@jeromecoutant IAR and GCC files are updated. Please review

LMESTM

I'm ok with the changes.
Would be just great to add a few words in the commit messages themselves, basically a kind of copy of #8004 description that explains that been breaking change when removing --legacyalign compile option (or at least this is my understanding ..)

LMESTM · 2018-09-18T15:41:49Z

...ts/TARGET_STM/TARGET_STM32F1/TARGET_NUCLEO_F103RB/device/TOOLCHAIN_ARM_MICRO/stm32f103xb.sct

@@ -35,8 +35,8 @@ LR_IROM1 0x08000000 0x20000  {    ; load region size_region (128K)
   .ANY (+RO)
  }

-  ; 59 vectors (16 core + 43 peripheral) * 4 bytes = 236 bytes to reserve (0xEC)
-  RW_IRAM1 (0x20000000+0xEC) (0x5000-0xEC)  {  ; RW data
+  ; 59 vectors (16 core + 43 peripheral) * 4 bytes = 236 bytes to reserve (0xEC+0x4)


please add a comment that says +0x04 says it's for overall 8 bytes alignment

bcostm

OK for me. It seems this PR is only for STM32 devices, so maybe add "STM32:" in the PR title ?

JanneKiiskila · 2018-09-19T09:16:42Z

We should do the rest of the chips as well, not just STM (just my humble opinion). This is a quite large change - it's trivial, but amount of files modified is quite large. My 1st scan on this (when I stated there's more than >250 files impacted) missed actually quite a few files...

deepikabhavnani · 2018-09-19T11:32:49Z

#8024 #8186

jeromecoutant

ST CI tests OK

cmonr · 2018-09-29T18:35:52Z

/morph build

mbed-ci · 2018-09-29T21:36:12Z

Build : SUCCESS

Build number : 3196
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8013/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-09-29T23:31:00Z

Exporter Build : SUCCESS

Build number : 2788
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8013/

mbed-ci · 2018-09-30T02:03:15Z

Test : FAILURE

Build number : 2996
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8013/2996

0xc0170 · 2018-10-01T08:49:48Z

The test failure not related to this changeset, we will restart after 5.10.1 RC is completed

NirSonnenschein · 2018-10-03T09:44:59Z

/morph build

mbed-ci · 2018-10-09T18:18:05Z

Test : FAILURE

Build number : 3102
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8013/3102

cmonr · 2018-10-09T18:18:28Z

Stopped job because it's consistently failing against NUCLEO_F207ZG.

0xc0170 · 2018-10-09T18:30:07Z

Stopped job because it's consistently failing against NUCLEO_F207ZG.

From the changes, I do not see why it would fail @ARMmbed/team-st-mcd any pointers?

…r files --legacyalign, --no_legacyalign are deprecated from ARMC6 compiler, in order to remove deprecated flags all linker files should strictly align to 8-byte boundary

deepikabhavnani · 2018-10-09T19:47:52Z

Got the culprit..

-/* 8-byte aligned(0x184) = 0x188
+/* 8-byte aligned(0x184) = 0x188 */

0xc0170 · 2018-10-09T21:26:06Z

/morph build

mbed-ci · 2018-10-09T22:21:27Z

Build : SUCCESS

Build number : 3301
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8013/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-10-10T00:11:43Z

Exporter Build : SUCCESS

Build number : 2936
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8013/

mbed-ci · 2018-10-10T06:30:57Z

Test : SUCCESS

Build number : 3110
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8013/3110

cmonr · 2018-10-18T02:56:36Z

#8024 supercedes this PR.
Patch creation complains about empty patch.

cmonr · 2018-10-18T03:01:48Z

Adding label back in. Not convinced this isn't an ordering issue.

adbridge · 2018-10-19T09:37:40Z

Mmm can't see why this won't automatically apply to the release. Will try manually patching this when all others have gone in...

cmonr requested a review from JanneKiiskila September 6, 2018 00:19

deepikabhavnani closed this Sep 6, 2018

deepikabhavnani reopened this Sep 6, 2018

deepikabhavnani force-pushed the stm_fix_align branch from 1848571 to a8ec28c Compare September 6, 2018 18:48

0xc0170 added the needs: review label Sep 7, 2018

deepikabhavnani force-pushed the stm_fix_align branch from a8ec28c to 304e358 Compare September 7, 2018 16:50

LMESTM approved these changes Sep 18, 2018

View reviewed changes

deepikabhavnani force-pushed the stm_fix_align branch from ce1df12 to a44ccf1 Compare September 18, 2018 19:16

bcostm approved these changes Sep 19, 2018

View reviewed changes

deepikabhavnani changed the title ~~Fix alignment of execute region to 8byte boundary~~ STM32: Fix alignment of execute region to 8byte boundary Sep 19, 2018

jeromecoutant approved these changes Sep 20, 2018

View reviewed changes

0xc0170 approved these changes Sep 24, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: review labels Sep 24, 2018

This was referenced Sep 24, 2018

Fix alignment of execute region to 8byte boundary #8024

Merged

Freescale/NXP: Fix alignment of execute region to 8byte boundary #8186

Merged

cmonr added needs: work and removed needs: CI labels Oct 9, 2018

[ST]: Fix alignment of execute region to 8-byte boundary in ARM linke…

bf1a2c8

…r files --legacyalign, --no_legacyalign are deprecated from ARMC6 compiler, in order to remove deprecated flags all linker files should strictly align to 8-byte boundary

deepikabhavnani force-pushed the stm_fix_align branch from 1970647 to bf1a2c8 Compare October 9, 2018 19:47

cmonr added needs: CI and removed needs: work labels Oct 9, 2018

NirSonnenschein added ready for merge and removed needs: CI labels Oct 10, 2018

cmonr merged commit 4903f32 into ARMmbed:master Oct 10, 2018

cmonr removed the ready for merge label Oct 10, 2018

deepikabhavnani deleted the stm_fix_align branch October 10, 2018 14:40

jeromecoutant mentioned this pull request Oct 11, 2018

Update devices to have minimum 2K RAM and heap, also added test #5285

Merged

cmonr removed the release-version: 5.10.2 label Oct 18, 2018

cmonr added the release-version: 5.10.2 label Oct 18, 2018

mattbrown015 mentioned this pull request Oct 18, 2018

STM32: #8286 Causes Tickless RTC Mode App to Hang #8473

Closed

adbridge removed the release-version: 5.10.2 label Oct 19, 2018

adbridge added the release-version: 5.10.2 label Oct 19, 2018

bcostm mentioned this pull request Oct 26, 2018

NUCLEO_L4R5ZI: Fix alignment of execute region to 8byte boundary #8554

Merged

kjbracey mentioned this pull request Jun 26, 2019

bootloader: Fix LPC55S69 bootloader segmentation #10791

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

STM32: Fix alignment of execute region to 8byte boundary #8013

STM32: Fix alignment of execute region to 8byte boundary #8013

deepikabhavnani commented Sep 5, 2018

JanneKiiskila commented Sep 5, 2018

deepikabhavnani commented Sep 5, 2018

deepikabhavnani commented Sep 6, 2018

jeromecoutant commented Sep 7, 2018

jeromecoutant commented Sep 7, 2018

deepikabhavnani commented Sep 12, 2018

LMESTM left a comment

LMESTM Sep 18, 2018

bcostm left a comment

JanneKiiskila commented Sep 19, 2018

deepikabhavnani commented Sep 19, 2018 •

edited

Loading

jeromecoutant left a comment

cmonr commented Sep 29, 2018

mbed-ci commented Sep 29, 2018

mbed-ci commented Sep 29, 2018

mbed-ci commented Sep 30, 2018

0xc0170 commented Oct 1, 2018

NirSonnenschein commented Oct 3, 2018

mbed-ci commented Oct 9, 2018

cmonr commented Oct 9, 2018

0xc0170 commented Oct 9, 2018

deepikabhavnani commented Oct 9, 2018

0xc0170 commented Oct 9, 2018

mbed-ci commented Oct 9, 2018

mbed-ci commented Oct 10, 2018

mbed-ci commented Oct 10, 2018

cmonr commented Oct 18, 2018

cmonr commented Oct 18, 2018

adbridge commented Oct 19, 2018

STM32: Fix alignment of execute region to 8byte boundary #8013

STM32: Fix alignment of execute region to 8byte boundary #8013

Conversation

deepikabhavnani commented Sep 5, 2018

Description

Pull request type

JanneKiiskila commented Sep 5, 2018

deepikabhavnani commented Sep 5, 2018

deepikabhavnani commented Sep 6, 2018

jeromecoutant commented Sep 7, 2018

jeromecoutant commented Sep 7, 2018

deepikabhavnani commented Sep 12, 2018

LMESTM left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

bcostm left a comment

Choose a reason for hiding this comment

JanneKiiskila commented Sep 19, 2018

deepikabhavnani commented Sep 19, 2018 • edited Loading

jeromecoutant left a comment

Choose a reason for hiding this comment

cmonr commented Sep 29, 2018

mbed-ci commented Sep 29, 2018

Triggering tests

mbed-ci commented Sep 29, 2018

mbed-ci commented Sep 30, 2018

0xc0170 commented Oct 1, 2018

NirSonnenschein commented Oct 3, 2018

mbed-ci commented Oct 9, 2018

cmonr commented Oct 9, 2018

0xc0170 commented Oct 9, 2018

deepikabhavnani commented Oct 9, 2018

0xc0170 commented Oct 9, 2018

mbed-ci commented Oct 9, 2018

Triggering tests

mbed-ci commented Oct 10, 2018

mbed-ci commented Oct 10, 2018

cmonr commented Oct 18, 2018

cmonr commented Oct 18, 2018

adbridge commented Oct 19, 2018

deepikabhavnani commented Sep 19, 2018 •

edited

Loading