Nuvoton: Fix mbed_hal-sleep test failed #8049

ccli8 · 2018-09-10T07:10:24Z

Description

This PR tries to fix mbed_hal-sleep test failure on Nuvoton targets. It includes:

Replace wait_us with nu_busy_wait_us in lp ticker since wait_us is not available with us ticker layer shutting down in the test.
Fix serial corruption due to entering deep sleep
Update M2351 secure library/executable

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

…imer.c from nu_timer.h

nu_busy_wait_us is a replacement for wait_us when intermediary us ticker layer is disabled.

nu_delay_cycle_x4 is a replacement for wait_us when us ticker is not available.

Replace wait_us with nu_busy_wait_us in lp_ticker since wait_us is not allowed in sleep test which would suspend us ticker layer on which wait_us relies. nu_busy_wait_us is implemented by calling us ticker HAL API directly rather than relying on us ticker layer.

Prevent deep sleep when there is still any character being transmitted on the UART. This allows tickless to be safely enabled.

Add secure functions CLK_PowerDown_S/CLK_Idle_S

1. Remove hal_sleep/hal_deepsleep from secure library 2. Add CLK_Idle_S/CLK_PowerDown_S

adbridge · 2018-09-10T11:12:49Z

@ARMmbed/mbed-os-hal please review

jamesbeyond · 2018-09-10T12:31:31Z

Hi @fkjagodzinski , do you mind have a look?

fkjagodzinski · 2018-09-14T15:10:01Z

targets/TARGET_NUVOTON/TARGET_NUC472/serial_api.c

@@ -1136,4 +1139,23 @@ static int serial_is_irq_en(serial_t *obj, SerialIrq irq)
 }

 #endif  // #if DEVICE_SERIAL_ASYNCH
+
+bool serial_can_deep_sleep(void)


I think the code of this fun is the same for every target in this PR. It might be a good idea to move it to a common file.

@fkjagodzinski serial_can_deep_sleep is recommended in #7698 by @c1728p9 , but it is not defined in HAL spec. I can only fix on Nuvoton targets.

Oh, I wasn't aware of the origin of this function. This could be a useful HAL feature. 👍

Anyway, my original comment was only about your new code. It might be convenient not to keep a few copies of one function. In this case it would stay inside targets/TARGET_NUVOTON/.

@fkjagodzinski Currently, on Nuvoton targets, HAL implementations (e.g. serial_api.c) for each target (NUMAKER_PFM_NUC472, NUMAKER_PFM_M453, etc.) are branched. Except these HAL implementations are resolved to merge into one, serial_can_deep_sleep would be kept branched for consistency.

Sure, no problem for me.

0xc0170 · 2018-09-19T12:37:41Z

...VOTON/TARGET_M2351/TARGET_NUMAKER_PFM_M2351/TARGET_M23_NS/NuMaker-mbed-TZ-secure-example.hex

@@ -1,797 +1,873 @@
 :020000040000FA
-:1000000000080020050F0000D90B0000D90B0000EC
+:1000000000080020AB100000190D0000190D0000C1


Should this file and also another object file in the same folder contain a license file? (https://github.com/ARMmbed/mbed-os/tree/a65e3d42e53e5c46c8a5bd74f17c5d0e7cef0f1b/targets/TARGET_NUVOTON/TARGET_M2351/TARGET_NUMAKER_PFM_M2351/TARGET_M23_NS)

Would be good to have it as a separate PR

@0xc0170 The Permissive Binary License meets the scenario. Could we reuse this license just like it is attached in https://github.com/ARMmbed/mbed-os/tree/master/tools/bootloaders/MTB_MTS_DRAGONFLY?
@cyliangtw

Yes.

Regarding this hex file - what does it do as it has suffix -example ?

@0xc0170 Thanks.

Regarding this hex file - what does it do as it has suffix -example ?

TrustZone target requires two codes, secure and non-secure. Secure code would run first to set up security environment and then bring up non-secure code. NuMaker-mbed-TZ-secure-example.hex is the default secure code (and cmse_lib.o is the secure gateway library exported by it). It is built from:
https://github.com/OpenNuvoton/NuMaker-mbed-TZ-secure-example
We choose .hex rather than .bin as output format because secure/non-secure code may not start at address 0x0. To flash secure/non-secure code on M2351, we would drag-n-drop NuMaker-mbed-TZ-secure-example.hex first and then user program e.g. mbed-os-example-blinky.hex.

cmonr · 2018-09-29T18:36:36Z

/morph build

mbed-ci · 2018-09-29T22:55:07Z

Build : SUCCESS

Build number : 3198
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8049/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

mbed-ci · 2018-09-30T01:06:36Z

Exporter Build : SUCCESS

Build number : 2790
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8049/

mbed-ci · 2018-09-30T06:15:38Z

Test : SUCCESS

Build number : 2998
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8049/2998

ccli8 added 7 commits September 10, 2018 10:55

[Nuvoton] Move nu_countdown_init/expired/free implementations to nu_t…

2b632b9

…imer.c from nu_timer.h

[Nuvoton] Add nu_busy_wait_us

88b9f20

nu_busy_wait_us is a replacement for wait_us when intermediary us ticker layer is disabled.

[Nuvoton] Add nu_delay_cycle_x4

26c0444

nu_delay_cycle_x4 is a replacement for wait_us when us ticker is not available.

[Nuvoton] Fix serial corruption due to deep sleep

beb04a8

Prevent deep sleep when there is still any character being transmitted on the UART. This allows tickless to be safely enabled.

[M2351] Fix hal_deepsleep with serial_can_deep_sleep

0550de7

Add secure functions CLK_PowerDown_S/CLK_Idle_S

[M2351] Update secure library/executable

a65e3d4

1. Remove hal_sleep/hal_deepsleep from secure library 2. Add CLK_Idle_S/CLK_PowerDown_S

ccli8 mentioned this pull request Sep 10, 2018

mbed_hal-sleep test fails on NUMAKER_PFM_M2351 #8043

Closed

adbridge added the needs: review label Sep 10, 2018

adbridge requested a review from a team September 10, 2018 11:13

fkjagodzinski approved these changes Sep 14, 2018

View reviewed changes

cmonr added the release-version: 5.10.1 label Sep 19, 2018

0xc0170 approved these changes Sep 19, 2018

View reviewed changes

0xc0170 added needs: CI and removed needs: review release-version: 5.10.1 labels Sep 19, 2018

ccli8 mentioned this pull request Sep 20, 2018

M2351: Add license file for default secure library/executable #8193

Merged

0xc0170 added ready for merge release-version: 5.10.2 and removed needs: CI labels Oct 1, 2018

0xc0170 merged commit 59ce41f into ARMmbed:master Oct 1, 2018

0xc0170 removed the ready for merge label Oct 1, 2018

ccli8 deleted the nuvoton_fix_hal_sleep branch October 2, 2018 03:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Nuvoton: Fix mbed_hal-sleep test failed #8049

Nuvoton: Fix mbed_hal-sleep test failed #8049

ccli8 commented Sep 10, 2018

adbridge commented Sep 10, 2018

jamesbeyond commented Sep 10, 2018

fkjagodzinski Sep 14, 2018

ccli8 Sep 17, 2018

fkjagodzinski Sep 17, 2018

ccli8 Sep 18, 2018

fkjagodzinski Sep 18, 2018

0xc0170 Sep 19, 2018

ccli8 Sep 20, 2018

0xc0170 Sep 20, 2018

ccli8 Sep 20, 2018

cmonr commented Sep 29, 2018

mbed-ci commented Sep 29, 2018

mbed-ci commented Sep 30, 2018

mbed-ci commented Sep 30, 2018

Nuvoton: Fix mbed_hal-sleep test failed #8049

Nuvoton: Fix mbed_hal-sleep test failed #8049

Conversation

ccli8 commented Sep 10, 2018

Description

Pull request type

adbridge commented Sep 10, 2018

jamesbeyond commented Sep 10, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

cmonr commented Sep 29, 2018

mbed-ci commented Sep 29, 2018

Triggering tests

mbed-ci commented Sep 30, 2018

mbed-ci commented Sep 30, 2018