Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MIMXRT1050_EVK: Fix the PWM Hal driver #8099

Merged
merged 1 commit into from
Sep 26, 2018
Merged

MIMXRT1050_EVK: Fix the PWM Hal driver #8099

merged 1 commit into from
Sep 26, 2018

Conversation

mmahadevan108
Copy link
Contributor

@mmahadevan108 mmahadevan108 commented Sep 12, 2018 •
edited
Loading

Description

  1. Add Pin defines for missing PWM pins
  2. Update the hal to account for the number of PWM instances
  3. Fix the register reload policy
  4. Configure the XBAR to put the PWM fault inputs in inactive state

After the fix, the platform passes the ci-test shield PWM tests.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@mmahadevan108
MIMXRT1050_EVK: Fix the PWM Hal driver
3661dc7 
1. Add Pin defines for missing PWM pins
2. Update the hal to account for the number of PWM instances
3. Fix the register reload policy
4. Configure the XBAR to put the PWM fault inputs in inactive state

Signed-off-by: Mahesh Mahadevan <mahesh.mahadevan@nxp.com>
@mmahadevan108
Copy link
Contributor Author

cc @0xc0170 @cmonr @maclobdell

@cmonr
Copy link
Contributor

cmonr commented Sep 20, 2018

@maclobdell Mind taking a look at this?

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 26, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 26, 2018

Build : FAILURE

Build number : 3162
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8099/

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 26, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 26, 2018

Build : SUCCESS

Build number : 3164
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8099/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 26, 2018

Exporter Build : SUCCESS

Build number : 2765
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8099/

@mbed-ci
Copy link

mbed-ci commented Sep 26, 2018

Test : SUCCESS

Build number : 2972
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8099/2972

@cmonr cmonr merged commit b3fe04f into ARMmbed:master Sep 26, 2018
@mmahadevan108 mmahadevan108 deleted the Fix_MXRT_PWM branch September 27, 2018 13:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@maclobdell maclobdell Awaiting requested review from maclobdell

@cmonr cmonr Awaiting requested review from cmonr

Assignees
No one assigned
Labels
release-version: 5.10.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mmahadevan108 @cmonr @0xc0170 @mbed-ci