Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests: add code coverage filtering #8154

Merged
merged 2 commits into from Sep 26, 2018
Merged

Unit tests: add code coverage filtering #8154

merged 2 commits into from Sep 26, 2018

Conversation

lorjala
Copy link
Contributor

@lorjala lorjala commented Sep 17, 2018

Description

Running with regular expressions now works for code coverage filtering. In addition, headers removed automatically from the report. Use (--include-headers) flag to include headers.

Soft depends on #8153.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Breaking change

@lorjala
Copy link
Contributor Author

lorjala commented Sep 17, 2018

@0xc0170 0xc0170 requested a review from a team September 17, 2018 14:14
Copy link
Contributor

@cmonr cmonr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left a suggestion.

"--html-detail",
"-o",
"./coverage/index.html"])
elif coverage_type == "xml":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you want to add, but it might be a good idea to catch/indicate if an invalid coverage_type is provided.

@cmonr
Copy link
Contributor

cmonr commented Sep 17, 2018

@lorjala What does

Soft depends on #8153.
mean?

Does it mean that #8153 should come in first, even though there's no hard order requirement?

@lorjala
Copy link
Contributor Author

lorjala commented Sep 18, 2018

@cmonr #8153 should come in first, but they can be merged in any order.

@cmonr
Copy link
Contributor

cmonr commented Sep 19, 2018

This needs a rebase. We'll start CI immediately after.

@lorjala
Copy link
Contributor Author

lorjala commented Sep 19, 2018

@cmonr @0xc0170 trigger build

@OPpuolitaival
Copy link
Contributor

This does not need any build.. current test builds are not testing anything inside UNITTEST folder. Discussed about this today with @0xc0170

@cmonr
Copy link
Contributor

cmonr commented Sep 22, 2018

Will hold off on starting tests pending a discussion/alignment here: #8138 (comment)

I'd like to avoid what might seem like arbitrary CI skipping for PRs, and instead have something we could publicly point to when we do skip tests, so that we can easily clear up misunderstandings with users.

This also now needs a rebase.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 24, 2018

Meanwhile, can we rebase and restart CI to move this forward?

@lorjala
Copy link
Contributor Author

lorjala commented Sep 24, 2018

@0xc0170 rebased.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 24, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 24, 2018

Build : SUCCESS

Build number : 3150
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8154/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 24, 2018

@mbed-ci
Copy link

mbed-ci commented Sep 25, 2018

@cmonr
Copy link
Contributor

cmonr commented Sep 25, 2018

/morph test

@mbed-ci
Copy link

mbed-ci commented Sep 25, 2018

@0xc0170 0xc0170 merged commit fc820f5 into ARMmbed:master Sep 26, 2018
@lorjala lorjala deleted the unittests-coveragefiltering branch November 19, 2018 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants