New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unit tests: add code coverage filtering #8154

Merged
merged 2 commits into from Sep 26, 2018

Conversation

Projects
None yet
7 participants
@lorjala
Contributor

lorjala commented Sep 17, 2018

Description

Running with regular expressions now works for code coverage filtering. In addition, headers removed automatically from the report. Use (--include-headers) flag to include headers.

Soft depends on #8153.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[x] Functionality change
[ ] Breaking change
@lorjala

This comment has been minimized.

Contributor

lorjala commented Sep 17, 2018

@0xc0170 0xc0170 requested a review from ARMmbed/mbed-os-tools Sep 17, 2018

@cmonr

cmonr approved these changes Sep 17, 2018

LGTM, left a suggestion.

"--html-detail",
"-o",
"./coverage/index.html"])
elif coverage_type == "xml":

This comment has been minimized.

@cmonr

cmonr Sep 17, 2018

Contributor

Not sure if you want to add, but it might be a good idea to catch/indicate if an invalid coverage_type is provided.

@cmonr cmonr added needs: CI and removed needs: review labels Sep 17, 2018

@cmonr cmonr requested a review from OPpuolitaival Sep 17, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 17, 2018

@lorjala What does

Soft depends on #8153.
mean?

Does it mean that #8153 should come in first, even though there's no hard order requirement?

@lorjala

This comment has been minimized.

Contributor

lorjala commented Sep 18, 2018

@cmonr #8153 should come in first, but they can be merged in any order.

@cmonr cmonr added needs: work and removed needs: CI labels Sep 19, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 19, 2018

This needs a rebase. We'll start CI immediately after.

@lorjala lorjala force-pushed the lorjala:unittests-coveragefiltering branch from 7325ce9 to 5546088 Sep 19, 2018

@lorjala

This comment has been minimized.

Contributor

lorjala commented Sep 19, 2018

@cmonr @0xc0170 trigger build

@OPpuolitaival

This comment has been minimized.

Contributor

OPpuolitaival commented Sep 19, 2018

This does not need any build.. current test builds are not testing anything inside UNITTEST folder. Discussed about this today with @0xc0170

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 22, 2018

Will hold off on starting tests pending a discussion/alignment here: #8138 (comment)

I'd like to avoid what might seem like arbitrary CI skipping for PRs, and instead have something we could publicly point to when we do skip tests, so that we can easily clear up misunderstandings with users.

This also now needs a rebase.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 24, 2018

Meanwhile, can we rebase and restart CI to move this forward?

@lorjala lorjala force-pushed the lorjala:unittests-coveragefiltering branch from 5546088 to 00397b2 Sep 24, 2018

@lorjala

This comment has been minimized.

Contributor

lorjala commented Sep 24, 2018

@0xc0170 rebased.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 24, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 24, 2018

Build : SUCCESS

Build number : 3150
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8154/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 25, 2018

/morph test

@mbed-ci

This comment has been minimized.

@cmonr cmonr added ready for merge and removed needs: CI labels Sep 26, 2018

@0xc0170 0xc0170 merged commit fc820f5 into ARMmbed:master Sep 26, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 612 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9098 cycles (-1131 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@lorjala lorjala deleted the lorjala:unittests-coveragefiltering branch Nov 19, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment