New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit tests: add code coverage filtering #8154
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left a suggestion.
"--html-detail", | ||
"-o", | ||
"./coverage/index.html"]) | ||
elif coverage_type == "xml": |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if you want to add, but it might be a good idea to catch/indicate if an invalid coverage_type is provided.
This needs a rebase. We'll start CI immediately after. |
This does not need any build.. current test builds are not testing anything inside UNITTEST folder. Discussed about this today with @0xc0170 |
Will hold off on starting tests pending a discussion/alignment here: #8138 (comment) I'd like to avoid what might seem like arbitrary CI skipping for PRs, and instead have something we could publicly point to when we do skip tests, so that we can easily clear up misunderstandings with users. This also now needs a rebase. |
Meanwhile, can we rebase and restart CI to move this forward? |
@0xc0170 rebased. |
/morph build |
Build : SUCCESSBuild number : 3150 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2755 |
Test : FAILUREBuild number : 2955 |
/morph test |
Test : SUCCESSBuild number : 2964 |
Description
Running with regular expressions now works for code coverage filtering. In addition, headers removed automatically from the report. Use (--include-headers) flag to include headers.
Soft depends on #8153.
Pull request type