Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mbed-cloud-sdk in requirements.txt #8160

Merged
merged 1 commit into from Sep 20, 2018
Merged

Update mbed-cloud-sdk in requirements.txt #8160

merged 1 commit into from Sep 20, 2018

Conversation

cmonr
Copy link
Contributor

@cmonr cmonr commented Sep 18, 2018

Description

Fixes #8143

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@cmonr
Copy link
Contributor Author

cmonr commented Sep 18, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Sep 18, 2018

Build : SUCCESS

Build number : 3088
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8160/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Sep 18, 2018

@mbed-ci
Copy link

mbed-ci commented Sep 18, 2018

Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still do not understand why we are so strict (==) instead of >= which would actually also fix this. any upcoming patch will require this update, not ideal?

To take any upcoming patch and minor but not major would as a fix?

@cmonr
Copy link
Contributor Author

cmonr commented Sep 18, 2018

@0xc0170 I was following the style that was there before.

I'm actually of the opinion that ALL requirements should be pinned against specific versions, only updating version numbers once they're tested and in CI.

@cmonr
Copy link
Contributor Author

cmonr commented Sep 18, 2018

@MarceloSalazar @teetak01 Any preference one way or another?

@MarceloSalazar
Copy link

My preference is to have fixed versions, so we can guarantee reproducibility by anyone.
Loose dependencies mean we don't have control.

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 20, 2018

Loose dependencies mean we don't have control.

Depends on how loose we choose. Updating to a patch release should be safe anytime. having strong version match as in here will result in updating it often. As it was before ==, I won't challenge it here but will take this to a new issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants