New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mbed-cloud-sdk in requirements.txt #8160

Merged
merged 1 commit into from Sep 20, 2018

Conversation

Projects
None yet
4 participants
@cmonr
Contributor

cmonr commented Sep 18, 2018

Description

Fixes #8143

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change
@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 18, 2018

/morph build

@cmonr cmonr requested a review from ARMmbed/mbed-os-maintainers Sep 18, 2018

@mbed-ci

This comment has been minimized.

mbed-ci commented Sep 18, 2018

Build : SUCCESS

Build number : 3088
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8160/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170

0xc0170 requested changes Sep 18, 2018 edited

I still do not understand why we are so strict (==) instead of >= which would actually also fix this. any upcoming patch will require this update, not ideal?

To take any upcoming patch and minor but not major would as a fix?

@0xc0170 0xc0170 added needs: work and removed needs: CI labels Sep 18, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 18, 2018

@0xc0170 I was following the style that was there before.

I'm actually of the opinion that ALL requirements should be pinned against specific versions, only updating version numbers once they're tested and in CI.

@cmonr

This comment has been minimized.

Contributor

cmonr commented Sep 18, 2018

@MarceloSalazar @teetak01 Any preference one way or another?

@MarceloSalazar

This comment has been minimized.

Contributor

MarceloSalazar commented Sep 18, 2018

My preference is to have fixed versions, so we can guarantee reproducibility by anyone.
Loose dependencies mean we don't have control.

@0xc0170

This comment has been minimized.

Member

0xc0170 commented Sep 20, 2018

Loose dependencies mean we don't have control.

Depends on how loose we choose. Updating to a patch release should be safe anytime. having strong version match as in here will result in updating it often. As it was before ==, I won't challenge it here but will take this to a new issue.

@0xc0170 0xc0170 added ready for merge and removed needs: work labels Sep 20, 2018

@cmonr cmonr merged commit 1cd9e91 into master Sep 20, 2018

16 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0.0%) RAM(+0.0%)
Details
continuous-integration/jenkins/branch This commit looks good
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details
jenkins-ci/cloud_client_smoke_test Test job: successful
Details
travis-ci/astyle Passed, 599 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 9892 cycles (+757 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Sep 20, 2018

@cmonr cmonr deleted the i.8143-1 branch Sep 26, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment