-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update mbed-cloud-sdk in requirements.txt #8160
Conversation
/morph build |
Build : SUCCESSBuild number : 3088 Triggering tests/morph test |
Test : SUCCESSBuild number : 2876 |
Exporter Build : SUCCESSBuild number : 2698 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I still do not understand why we are so strict (==
) instead of >=
which would actually also fix this. any upcoming patch will require this update, not ideal?
To take any upcoming patch and minor but not major would as a fix?
@0xc0170 I was following the style that was there before. I'm actually of the opinion that ALL requirements should be pinned against specific versions, only updating version numbers once they're tested and in CI. |
@MarceloSalazar @teetak01 Any preference one way or another? |
My preference is to have fixed versions, so we can guarantee reproducibility by anyone. |
Depends on how loose we choose. Updating to a patch release should be safe anytime. having strong version match as in here will result in updating it often. As it was before |
Description
Fixes #8143
Pull request type