Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warnings in block devices #8256

Merged
merged 1 commit into from
Oct 11, 2018
Merged

Fix warnings in block devices #8256

merged 1 commit into from
Oct 11, 2018

Conversation

yossi2le
Copy link
Contributor

Description

This PR intends to fix compilation warnings of in block devices as described in issue #8198
Affected block devices list:

  • SPIFBlockDevice.cpp
  • BufferedBlockDevice.cpp
  • ChainingBlockDevice.cpp
  • ExhaustibleBlockDevice.cpp
  • FlashSimBlockDevice.cpp

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Breaking change

@yossi2le yossi2le mentioned this pull request Sep 26, 2018
Closed
@0xc0170 0xc0170 requested a review from a team September 26, 2018 12:26
0xc0170
0xc0170 approved these changes Sep 26, 2018
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minimizing ⚠️ 👍

This was referenced Oct 9, 2018
Closed
Closed
@cmonr cmonr mentioned this pull request Oct 10, 2018
Closed
@NirSonnenschein
Copy link
Contributor

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 11, 2018

Build : SUCCESS

Build number : 3320
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8256/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 11, 2018

Exporter Build : SUCCESS

Build number : 2955
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8256/

@mbed-ci
Copy link

mbed-ci commented Oct 11, 2018

Test : SUCCESS

Build number : 3131
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8256/3131

@cmonr cmonr merged commit 0aed6bb into ARMmbed:master Oct 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@dannybenor dannybenor dannybenor approved these changes

Assignees
No one assigned
Labels
release-version: 5.10.2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@yossi2le @NirSonnenschein @mbed-ci @0xc0170 @dannybenor @cmonr