Rollup: Rerun multiple PRs through CI that have already indirectly passed #8367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description The VTOR reserves the lowest 7 bits. This PR changes the round up behavoir of the application offset to make sure that the address used for the in-flash vector table always ends in 7 0's. Fixes #7392 ### Pull request type [x] Fix [ ] Refactor [ ] Target update [ ] Functionality change [ ] Breaking change
### Description The netbeans exporter was being inconsistant with it's invocation of the C pre-processor on the linker script: the C pre-processor was always invoked from `$PATH` where as the rest of the tools were invoked as configured by the tools. This changes the invocation of CPP to match the rest of the tools: heed the conifguration. Fixes ARMmbed/mbed-cli#663 ### Pull request type [x] Fix [ ] Refactor [ ] Target update [ ] Functionality change [ ] Breaking change
…heotherjimmy-fix-7954
…2le/mbed-os into yossi2le-fix_warnings_in_blockdevices
…heotherjimmy-fix-7392
…mbed into theotherjimmy-nb-consistant-paths
…ridadan-remove_gcc_cr
|
/morph build |
Build : SUCCESSBuild number : 3316 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 2951 |
Test : SUCCESSBuild number : 3127 |
0xc0170
approved these changes
Oct 11, 2018
|
Fyi, this is now only waiting on the "continuous-integration/jenkins/branch" test, which appears to now be disabled in CI. I might recreate this PR using a forked branch instead of an ARMmbed branch. |
|
Closing since #8387 came in! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This concludes rollup/bundle PR testing for now.
Both previous rollup/bundle tests (#8356 and #8357) have completely passed CI, but due to early verification, the flow used to generate those PRs was undeveloped, which wouldn't yield the results we're looking for.
In addition, this rollup PR was generated using a simple bash script. The only manual intervention needed was the push of the new branch, and creation of the PR.
Included PRs:
How it works
Normally, we run CI against every single PR before merging it into the master branch. Once a PR passes and is merged, it's verified that it has a proper release label, so that the patch creation process can pull in the correct changes.
What rolling-up/bundling does is that instead of testing a single PR against CI, select PRs are merged into a temporary branch (rollup in this case), and a new PR is created to put this new branch against CI. Once it passes, the rollup PR is merged, and all rolled up PRs are automatically marked as merged and closed.
The rollup PR does not need nor should not get a release version label. Instead, the same process exists, where the individial PR should have a release version label.
For an example of what this looks like after the merge process, please refer to the following fork links:
Restrictions
For now, it is suggested that only PRs that are marked as
needs; CIand with the samerelease-version:labels be bundled. Other combinations are possible, but this should limit the scope of any debugging efforts that might be needed.Because of the numerous types of errors that could occur with a single PR, it is also suggested that the PRs be 1) tiny, and 2) orthogonal to each other. This way, if/when a test fails, determining where the problem within a set of PRs isn't the worst excercise in the world.
Pull request type