New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Mbed TLS platform error code and value #8434

Merged
merged 1 commit into from Oct 16, 2018

Conversation

Projects
None yet
6 participants
@RonEld
Contributor

RonEld commented Oct 15, 2018

Description

Change error from MBEDTLS_PLATFORM_HW_FAILED to
MBEDTLS_PLATFORM_HW_ACCEL_FAILED and the value to 0x70,
as the previous value cannot be used as a low level error code.
resolves #8433

Pull request type

[x ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change
Change Mbed TLS platform error code and value
Change error from `MBEDTLS_PLATFORM_HW_FAILED` to
`MBEDTLS_PLATFORM_HW_ACCEL_FAILED` and the value to 0x70,
as the previous value cannot be used as a low level error code.
@cmonr

cmonr approved these changes Oct 15, 2018

@RonEld

This comment has been minimized.

Contributor

RonEld commented Oct 15, 2018

@cmonr Thank for the review. Do you think it's better to remove MBEDTLS_ERR_PLATFORM_HW_FAILED altogether to avoid any misuse? Note it was added only for 5.10.0

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 15, 2018

@RonEld I would suggest leaving it in for now, since any code state removals could be seen as a breaking change and move the PR out to 5.11.

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 15, 2018

Build : SUCCESS

Build number : 3360
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8434/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 merged commit 8faf40e into ARMmbed:master Oct 16, 2018

15 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
jenkins-ci/cloud-client-test Success
Details
jenkins-ci/unittests Success
Details
travis-ci/astyle Passed, 658 files (+0 files)
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 10186 cycles (+248 cycles)
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B (+0.00%)
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment