Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Mbed TLS platform error code and value #8434

Merged
merged 1 commit into from
Oct 16, 2018

Conversation

RonEld
Copy link
Contributor

@RonEld RonEld commented Oct 15, 2018

Description

Change error from MBEDTLS_PLATFORM_HW_FAILED to
MBEDTLS_PLATFORM_HW_ACCEL_FAILED and the value to 0x70,
as the previous value cannot be used as a low level error code.
resolves #8433

Pull request type

[x ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Change error from `MBEDTLS_PLATFORM_HW_FAILED` to
`MBEDTLS_PLATFORM_HW_ACCEL_FAILED` and the value to 0x70,
as the previous value cannot be used as a low level error code.
@RonEld
Copy link
Contributor Author

RonEld commented Oct 15, 2018

@cmonr Thank for the review. Do you think it's better to remove MBEDTLS_ERR_PLATFORM_HW_FAILED altogether to avoid any misuse? Note it was added only for 5.10.0

@cmonr
Copy link
Contributor

cmonr commented Oct 15, 2018

@RonEld I would suggest leaving it in for now, since any code state removals could be seen as a breaking change and move the PR out to 5.11.

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 15, 2018

Build : SUCCESS

Build number : 3360
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8434/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 16, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 16, 2018

@0xc0170 0xc0170 merged commit 8faf40e into ARMmbed:master Oct 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

wrong value for Mbed TLS specific error
6 participants