Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Gemalto TCP Socket support #8440

Merged
merged 1 commit into from
Oct 27, 2018
Merged

Cellular: Gemalto TCP Socket support #8440

merged 1 commit into from
Oct 27, 2018

Conversation

kivaisan
Copy link
Contributor

@kivaisan kivaisan commented Oct 16, 2018

Description

Add TCP socket support for Gemalto cellular modem driver.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@kivaisan
Copy link
Contributor Author

@AriParkkila @jarvte @mirelachirica please review.

@cmonr
Copy link
Contributor

cmonr commented Oct 19, 2018

Info @ARMmbed/mbed-os-maintainers: Marking this for next patch since this is a target update.

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 24, 2018

@ARMmbed/mbed-os-wan Waiting for your review

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 24, 2018

[X] Functionality change

In this case, this is target update - updating target implementation

@cmonr
Copy link
Contributor

cmonr commented Oct 25, 2018

@mbed-os-wan @antiiv01 @mirelachirica @jarvte

Thoughts?

@0xc0170
Copy link
Contributor

0xc0170 commented Oct 25, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 25, 2018

Build : SUCCESS

Build number : 3463
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8440/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@cmonr
Copy link
Contributor

cmonr commented Oct 25, 2018

IAR network license issue.
Restarting.
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 25, 2018

@mbed-ci
Copy link

mbed-ci commented Oct 26, 2018

@cmonr
Copy link
Contributor

cmonr commented Oct 26, 2018

It's possible that the network slowed to a crawl with this test.
Retesting to verify.
/morph test

@mbed-ci
Copy link

mbed-ci commented Oct 26, 2018

@cmonr cmonr merged commit 737b36f into ARMmbed:master Oct 27, 2018
@cmonr cmonr removed the needs: CI label Oct 27, 2018
@adbridge
Copy link
Contributor

adbridge commented Nov 2, 2018

This sits on top of #8295 which is scheduled for 5.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants