New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding file type for linker script arg in make script #8495

Merged
merged 1 commit into from Oct 23, 2018

Conversation

Projects
None yet
4 participants
@bridadan
Contributor

bridadan commented Oct 22, 2018

Description

When supplying an external linker script, the tools currently traceback:

$ mbed compile --linker targets\TARGET_Freescale\TARGET_MCUXpresso_MCUS\TARGET_MCU_K64F\device\TOOLCHAIN_GCC_ARM\MK64FN1M0xxx12.ld
[mbed] Auto-installing missing Python modules...
c:\python27\lib\site-packages\requests\__init__.py:80: RequestsDependencyWarning: urllib3 (1.23) or chardet (3.0.4) doesn't match a supported version!
  RequestsDependencyWarning)
Building project mbed (NUCLEO_F411RE, GCC_ARM)
Scan: mbed
Scan: env
[ERROR] add_file_ref() takes exactly 4 arguments (3 given)
[mbed] ERROR: "c:\python27\python.exe" returned error.
       Code: 1
       Path: "C:\Users\bridan01\onedrive_arm\Documents\dev\m_mbed\mbed"
       Command: "c:\python27\python.exe -u C:\Users\bridan01\onedrive_arm\Documents\dev\m_mbed\mbed\tools\make.py -t GCC_ARM -m NUCLEO_F411RE --source . --build .\BUILD\NUCLEO_F411RE\GCC_ARM --linker targets\TARGET_Freescale\TARGET_MCUXpresso_MCUS\TARGET_MCU_K64F\device\TOOLCHAIN_GCC_ARM\MK64FN1M0xxx12.ld"
       Tip: You could retry the last command with "-v" flag for verbose output

This patch fixes the traceback.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@bridadan bridadan requested a review from theotherjimmy Oct 22, 2018

@cmonr cmonr added the needs: review label Oct 22, 2018

@cmonr

cmonr approved these changes Oct 22, 2018

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 22, 2018

So, funny thing.
This needs a rebase :/

@bridadan bridadan force-pushed the bridadan:patch_add_linker_line branch from 620f76d to b0264e3 Oct 22, 2018

@bridadan

This comment has been minimized.

Contributor

bridadan commented Oct 22, 2018

Rebased!

@cmonr

This comment has been minimized.

Contributor

cmonr commented Oct 23, 2018

/morph build

@mbed-ci

This comment has been minimized.

mbed-ci commented Oct 23, 2018

Build : SUCCESS

Build number : 3434
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8495/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci

This comment has been minimized.

@mbed-ci

This comment has been minimized.

@0xc0170 0xc0170 added ready for merge and removed needs: CI labels Oct 23, 2018

@cmonr cmonr merged commit e2298a7 into ARMmbed:master Oct 23, 2018

13 checks passed

ci-morph-build build completed
Details
ci-morph-exporter build completed
Details
ci-morph-mbed2-build build completed
Details
ci-morph-test test completed , RTOS ROM(+0 bytes) RAM(+0 bytes)
Details
continuous-integration/jenkins/pr-head This commit looks good
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
travis-ci/astyle Passed, 673 files
Details
travis-ci/docs Local docs testing has passed
Details
travis-ci/events Passed, runtime is 8930 cycles
Details
travis-ci/gitattributestest Local gitattributestest testing has passed
Details
travis-ci/licence_check Local licence_check testing has passed
Details
travis-ci/littlefs Passed, code size is 8372B
Details
travis-ci/tools-py2.7 Local tools-py2.7 testing has passed
Details

@cmonr cmonr removed the ready for merge label Oct 23, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment