Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add required namespace instead of relying on mbed.h #8550

Merged
merged 1 commit into from
Oct 30, 2018
Merged

Add required namespace instead of relying on mbed.h #8550

merged 1 commit into from
Oct 30, 2018

Conversation

deepikabhavnani
Copy link

Description

mbed.h has 'using namespace mbed;', hence some of the files skip adding required namespace to the code, it is always good to specify the namespace around the elements in header and using namespace in specific CPP files, instead of all

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Add required namespace instead of relying on mbed.h
451cf7c 
mbed.h has 'using namespace mbed;', hence some of the files skip
adding required namespace to the code, it is always good to specify the
namespace around the elements in header and `using namespace` in
specific CPP files, instead of all
pan-
pan- approved these changes Oct 25, 2018
View reviewed changes
Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the submission @deepikabhavnani .

@cmonr cmonr requested review from kjbracey and a team October 26, 2018 02:51
@deepikabhavnani
Copy link
Author

deepikabhavnani commented Oct 26, 2018 •
edited
Loading

@SenRamakri / @kegilbert - Please review

kegilbert
kegilbert approved these changes Oct 26, 2018
View reviewed changes
Copy link
Contributor

@kegilbert kegilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@cmonr
Copy link
Contributor

cmonr commented Oct 29, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 29, 2018

Build : FAILURE

Build number : 3499
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8550/

@cmonr
Copy link
Contributor

cmonr commented Oct 29, 2018

Will restart in a bit. 502 Gateway errors.

@cmonr
Copy link
Contributor

cmonr commented Oct 29, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Oct 29, 2018

Build : SUCCESS

Build number : 3501
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8550/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Oct 30, 2018

Exporter Build : SUCCESS

Build number : 3118
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/exporter/8550/

@mbed-ci
Copy link

mbed-ci commented Oct 30, 2018

Test : SUCCESS

Build number : 3285
Test logs :http://mbed-os-logs.s3-website-us-west-1.amazonaws.com/?prefix=logs/8550/3285

@cmonr cmonr merged commit 9226c58 into ARMmbed:master Oct 30, 2018
@adbridge
Copy link
Contributor

adbridge commented Nov 2, 2018

This functionality is only coming in for 5.11

@deepikabhavnani deepikabhavnani deleted the mbed_h_fixes branch November 2, 2018 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pan- pan- pan- approved these changes

@kegilbert kegilbert kegilbert approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@kjbracey kjbracey Awaiting requested review from kjbracey

Assignees
No one assigned
Labels
release-version: 5.11.0-rc1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@deepikabhavnani @cmonr @mbed-ci @adbridge @pan- @kegilbert @0xc0170