Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

realtek-rtl8195am-wifi-headerfile-updates #8750

Merged

Conversation

M-ichae-l
Copy link
Contributor

@M-ichae-l M-ichae-l commented Nov 15, 2018

Description

  1. add "extern "C" {} " to "wifi_ind.h" for being called by CPP files.
  2. fix for Unable to register for wifi status updates with Realtek 8195 #8481

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

1, add "extern "C" {}  " to "wifi_ind.h" for being called by CPP files.
@adbridge
Copy link
Contributor

adbridge commented Nov 15, 2018

@M-ichae-l Please note that the description template guidelines says not to edit the template in any way other than to add your description and add one X to one of the types. You have removed all the other types and thus modified the template. Can you please fix this.

@M-ichae-l
Copy link
Contributor Author

@adbridge
I have updated. If it is still not the requirements, do we have a way to revert all the changes in the Description?

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 16, 2018

If you click on edited above the comment, you can find the history there.

Thanks for the update, LGTM

@cmonr
Copy link
Contributor

cmonr commented Nov 17, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 17, 2018

Build : SUCCESS

Build number : 3661
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8750/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Nov 17, 2018

@NirSonnenschein
Copy link
Contributor

re-test to see if CI is more responsive
/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 18, 2018

Build : SUCCESS

Build number : 3662
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8750/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Nov 18, 2018

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 19, 2018

Info: This PR has been re-bundled into a new rollup PR (#8800).

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.
If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

@samchuarm
Copy link

Hi , since PR #8800 got closed, how do we proceed with this PR to fix issue #8481 ? Thanks.

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 22, 2018

Hi , since PR #8800 got closed, how do we proceed with this PR to fix issue #8481 ? Thanks.

I am on it. I might create a new rollup soon. Some PR from 8800 are ready for merge.

@0xc0170 0xc0170 mentioned this pull request Nov 22, 2018
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 22, 2018

Info: This PR has been re-bundled into a new rollup PR (#8838 ).

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.
If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

@0xc0170 0xc0170 merged commit c97d343 into ARMmbed:master Nov 24, 2018
@0xc0170 0xc0170 removed the needs: CI label Nov 24, 2018
@M-ichae-l M-ichae-l deleted the realtek-rtl8195am-wifi-headerfile-updates branch November 26, 2018 07:35
@M-ichae-l M-ichae-l restored the realtek-rtl8195am-wifi-headerfile-updates branch November 26, 2018 07:35
@cmonr cmonr removed the rollup PR label Nov 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants