Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: minor fix to CellularDevice and adding updating unit tests after refactoring #8751

Merged
merged 4 commits into from
Nov 19, 2018

Conversation

jarvte
Copy link
Contributor

@jarvte jarvte commented Nov 15, 2018

Description

Updated cellular unit tests after major refactor and introducing new class CellularContext.
Tests couldn't be done properly without the fix to class CellularDevice.cpp which was found while making unit tests.
Fix enables application to retry operation as internal state machine is deleted in case of failure when initializing state machine.

@AriParkkila @mirelachirica please review.

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 15, 2018

travis-ci/astyle — Passed, 62 files (+4 files)

Note, astyle will error soon on master. Please fix

@jarvte
Copy link
Contributor Author

jarvte commented Nov 16, 2018

@0xc0170 astyle run and fixed. What is the preferred way to run astyle?
For example cellular I use the following:
astyle -n --options=.astylerc --recursive features/cellular/.cpp
astyle -n --options=.astylerc --recursive features/cellular/
.h

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 16, 2018

@jarvte Also *.c files :-) But yes, the command looks fine. Sorry to request one more but would like to see it, if you rebase on top of latest master, we would get a new travis config and updated number of files (it was updated this morning, astyle should report 2 files only - we will fix it). Not mandatory though

@0xc0170 0xc0170 requested a review from a team November 16, 2018 10:29
@jarvte
Copy link
Contributor Author

jarvte commented Nov 16, 2018

@0xc0170 rebase done

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 16, 2018

I am checking travis failure, script is being terminated and reports an error 😕

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 16, 2018

@jarvte Can you add this commit here (https://github.com/ARMmbed/mbed-os/pull/8769/files) - should fix the error

Teppo Järvelin and others added 2 commits November 16, 2018 13:58
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 16, 2018

Travis astyle fixed 👍

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 16, 2018

/morph build

@mbed-ci
Copy link

mbed-ci commented Nov 16, 2018

Build : SUCCESS

Build number : 3647
Build artifacts/logs : http://mbed-os.s3-website-eu-west-1.amazonaws.com/?prefix=builds/8751/

Triggering tests

/morph test
/morph export-build
/morph mbed2-build

@mbed-ci
Copy link

mbed-ci commented Nov 16, 2018

@mbed-ci
Copy link

mbed-ci commented Nov 16, 2018

@jarvte jarvte deleted the ctx_unittests branch December 3, 2018 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants