-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cellular: minor fix to CellularDevice and adding updating unit tests after refactoring #8751
Conversation
Note, astyle will error soon on master. Please fix |
@0xc0170 astyle run and fixed. What is the preferred way to run astyle? |
@jarvte Also *.c files :-) But yes, the command looks fine. Sorry to request one more but would like to see it, if you rebase on top of latest master, we would get a new travis config and updated number of files (it was updated this morning, astyle should report 2 files only - we will fix it). Not mandatory though |
be52d7e
to
24213b4
Compare
@0xc0170 rebase done |
I am checking travis failure, script is being terminated and reports an error 😕 |
@jarvte Can you add this commit here (https://github.com/ARMmbed/mbed-os/pull/8769/files) - should fix the error |
Should not pick up .cmake files (just .c files)
Travis astyle fixed 👍 |
/morph build |
Build : SUCCESSBuild number : 3647 Triggering tests/morph test |
Exporter Build : SUCCESSBuild number : 3254 |
Test : SUCCESSBuild number : 3426 |
Description
Updated cellular unit tests after major refactor and introducing new class CellularContext.
Tests couldn't be done properly without the fix to class CellularDevice.cpp which was found while making unit tests.
Fix enables application to retry operation as internal state machine is deleted in case of failure when initializing state machine.
@AriParkkila @mirelachirica please review.
Pull request type