Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add platform TT_M3HQ #8815

Merged
merged 22 commits into from
Dec 28, 2018
Merged

Add platform TT_M3HQ #8815

merged 22 commits into from
Dec 28, 2018

Conversation

ThunderSoft123
Copy link
Contributor

Description

Add target TT_M3HQ which base Toshiba's TMPM3HQFDFG.

Pull request type

[ ] Fix
[ ] Refactor
[x] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 20, 2018

@ThunderSoft123 Can you please share the test results for this addition (all 3 toolchains) ?

@ThunderSoft123
Copy link
Contributor Author

The test results are as follows(WIN7, run "mbed test -t GCC_ARM/ARM/IAR -m TT_M3HQ"):
tt_m3hq_iar
tt_m3hq_gccarm
tt_m3hq_arm

@ThunderSoft123
Copy link
Contributor Author

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 26, 2018

@ThunderSoft123 👍 for sharing test results, I am reviewing the code now

@ThunderSoft123
Copy link
Contributor Author

@0xc0170 I forget to add code, but the us ticker test is ok. The API us_ticker_free code have been added.

targets/targets.json Outdated Show resolved Hide resolved
targets/TARGET_TT/mbed_rtx.h Outdated Show resolved Hide resolved
Copy link
Contributor

@ashok-rao ashok-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. Let's wait for CI results (when triggered). Thanks @ThunderSoft123 .

@ThunderSoft123
Copy link
Contributor Author

@0xc0170 When the CI finished?

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 6, 2018

@ThunderSoft123 Can you rebase this to get the latest master here? Travis will be fixed via rebase. And we will restart CI afterwards (will write here once CI started)

@cmonr
Copy link
Contributor

cmonr commented Dec 6, 2018

@ashok-rao Fyi, this PR needs a rebase to fix the travis-ci/pr status check.

@cmonr
Copy link
Contributor

cmonr commented Dec 7, 2018

@ThunderSoft123 Please undo the merge commit and instead rebase the PR.

A merge doesn't work with our PR process, as you can currently see in the PR's commit history.

@ThunderSoft123
Copy link
Contributor Author

@cmonr Please review it. Thank you.

*
* DO NOT USE THIS SOFTWARE WITHOUT THE SOFTWARE LICENSE AGREEMENT.
*
* (C)Copyright TOSHIBA MICROELECTRONICS CORPORATION 2017 All rights reserved
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dont see the license, neither agreement should be required? Can you please update peripheral driver license to be compatible with our licensing guidance ? Recommend using apache 2.0 as for the rest of files in this pull request

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 12, 2018

This needs rebase now as well (one conflict). As soon as done with the license, this will be ready for CI

@ThunderSoft123
Copy link
Contributor Author

@0xc0170 Sorry, I misoperate branch which pushing M4G9 code and undo the commit. So, I understand the M3HQ review have finished.

@cmonr
Copy link
Contributor

cmonr commented Dec 21, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 21, 2018

Test run: FAILED

Summary: 3 of 7 test jobs failed
Build number : 2
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_build-GCC_ARM
  • jenkins-ci/mbed-os-ci_build-ARM
  • jenkins-ci/mbed-os-ci_build-IAR

@0xc0170
Copy link
Contributor

0xc0170 commented Dec 21, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 21, 2018

Test run: FAILED

Summary: 1 of 11 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_greentea-test

@cmonr
Copy link
Contributor

cmonr commented Dec 21, 2018

Restarted greentea-test since CI failure appears unrelated.

@NirSonnenschein
Copy link
Contributor

Re-check CI

@NirSonnenschein
Copy link
Contributor

failure in tests seems to reproduce on multiple runs:
NUCLEO_F746ZG armcc / lp ticker interrupt test – NUCLEO_F746ZG-ARM.tests-mbed_hal-common_tickers

@ThunderSoft123
Copy link
Contributor Author

The TT_M3HQ don't support it(lp ticker).

@gaoshaohhua
Copy link

Can you please tell us what we need to do if there are some problems of CI-Test.(We need to complete the mbed certification as soon as possible, please help us to finish it)

@cmonr
Copy link
Contributor

cmonr commented Dec 27, 2018

@ThunderSoft123 @gaoshaohhua It seems that most people are out for the holidays this week.

Going to completely restart the CI job. I'm not seeing any reasons why this would/should be failing.

@cmonr
Copy link
Contributor

cmonr commented Dec 27, 2018

[1545413113.53][GLRM][INF] reset() failed
Process Process-1:
Traceback (most recent call last):
  File "/usr/lib/python2.7/multiprocessing/process.py", line 258, in _bootstrap
    self.run()
  File "/usr/lib/python2.7/multiprocessing/process.py", line 114, in run
    self._target(*self._args, **self._kwargs)
  File "build/bdist.linux-x86_64/egg/mbed_host_tests/host_tests_conn_proxy/conn_proxy.py", line 297, in conn_process
    sync_uuid = __send_sync(timeout=time_to_sync_again)
  File "build/bdist.linux-x86_64/egg/mbed_host_tests/host_tests_conn_proxy/conn_proxy.py", line 177, in __send_sync
    connector.reset()
  File "build/bdist.linux-x86_64/egg/mbed_host_tests/host_tests_conn_proxy/conn_primitive_remote.py", line 184, in reset
    self.__remote_reset()
  File "build/bdist.linux-x86_64/egg/mbed_host_tests/host_tests_conn_proxy/conn_primitive_remote.py", line 117, in __remote_reset
    if self.selected_resource.reset() is False:
  File "/usr/local/lib/python2.7/dist-packages/raas_client-0.11.2-py2.7.egg/raas_client/resources/Base.py", line 841, in reset
    raise ResourceError(error_msg)
ResourceError: Reset response(request_id: 5b49e41e-0545-11e9-8fe1-0242ac110004) failed with message: Serial proxy killed by SIGTERM

Looks like CI had trouble allocating the device for testing. Instead, will just restart jenkins-ci/greentea-test and monitor how device allocations are performing.

@gaoshaohhua
Copy link

@cmonr Got it. Please Notice us if there are some troubles.

@cmonr
Copy link
Contributor

cmonr commented Dec 28, 2018

@gaoshaohhua @ThunderSoft123 Looks like this was finally able to pass, and I think the test team has a short term task to look at the spurious failures.

@cmonr cmonr merged commit 51143ea into ARMmbed:master Dec 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants