-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add platform TT_M3HQ #8815
Add platform TT_M3HQ #8815
Conversation
@ThunderSoft123 Can you please share the test results for this addition (all 3 toolchains) ? |
@ThunderSoft123 👍 for sharing test results, I am reviewing the code now |
@0xc0170 I forget to add code, but the us ticker test is ok. The API us_ticker_free code have been added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM. Let's wait for CI results (when triggered). Thanks @ThunderSoft123 .
@0xc0170 When the CI finished? |
@ThunderSoft123 Can you rebase this to get the latest master here? Travis will be fixed via rebase. And we will restart CI afterwards (will write here once CI started) |
@ashok-rao Fyi, this PR needs a rebase to fix the |
@ThunderSoft123 Please undo the merge commit and instead rebase the PR. A merge doesn't work with our PR process, as you can currently see in the PR's commit history. |
d0cf870
to
c7ab0b6
Compare
@cmonr Please review it. Thank you. |
33ce91c
to
a31bd4b
Compare
* | ||
* DO NOT USE THIS SOFTWARE WITHOUT THE SOFTWARE LICENSE AGREEMENT. | ||
* | ||
* (C)Copyright TOSHIBA MICROELECTRONICS CORPORATION 2017 All rights reserved |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont see the license, neither agreement should be required? Can you please update peripheral driver license to be compatible with our licensing guidance ? Recommend using apache 2.0 as for the rest of files in this pull request
This needs rebase now as well (one conflict). As soon as done with the license, this will be ready for CI |
@0xc0170 Sorry, I misoperate branch which pushing M4G9 code and undo the commit. So, I understand the M3HQ review have finished. |
2e395f1
to
9efce25
Compare
CI started |
Test run: FAILEDSummary: 3 of 7 test jobs failed Failed test jobs:
|
CI started |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
Restarted greentea-test since CI failure appears unrelated. |
Re-check CI |
failure in tests seems to reproduce on multiple runs: |
The TT_M3HQ don't support it(lp ticker). |
Can you please tell us what we need to do if there are some problems of CI-Test.(We need to complete the mbed certification as soon as possible, please help us to finish it) |
@ThunderSoft123 @gaoshaohhua It seems that most people are out for the holidays this week. Going to completely restart the CI job. I'm not seeing any reasons why this would/should be failing. |
Looks like CI had trouble allocating the device for testing. Instead, will just restart |
@cmonr Got it. Please Notice us if there are some troubles. |
@gaoshaohhua @ThunderSoft123 Looks like this was finally able to pass, and I think the test team has a short term task to look at the spurious failures. |
Description
Add target TT_M3HQ which base Toshiba's TMPM3HQFDFG.
Pull request type