Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cellular: Fix bc95 to accept only RAT_NB1 #8847

Merged
merged 1 commit into from
Nov 25, 2018

Conversation

jarvte
Copy link
Contributor

@jarvte jarvte commented Nov 23, 2018

Fixed TODO comment by correct implementation:

RAT_NB1 is the only rat that bc95 supports so this fix prevents changing it some other.

@AriParkkila please review

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@0xc0170 0xc0170 changed the title Cellular: Fixed bc95 to accept only RAT_NB1 as it's only valid rat Cellular: Fix bc95 to accept only RAT_NB1 as it's only valid rat Nov 23, 2018
@0xc0170 0xc0170 changed the title Cellular: Fix bc95 to accept only RAT_NB1 as it's only valid rat Cellular: Fix bc95 to accept only RAT_NB1 Nov 23, 2018
@0xc0170
Copy link
Contributor

0xc0170 commented Nov 23, 2018

Note about the 1st line commit length (review how Github displayes it and git log - how it wraps), ideally first commit line 50 char

@0xc0170
Copy link
Contributor

0xc0170 commented Nov 24, 2018

Info: This PR has been re-bundled into a new rollup PR (#8862).

No further work is needed here, as once that PR is merged, this PR will also be closed and marked as merged.
If any more commits are made in this PR, this PR will remain open and have to go through CI on its own.

@0xc0170 0xc0170 merged commit 9095635 into ARMmbed:master Nov 25, 2018
@0xc0170 0xc0170 removed the needs: CI label Nov 25, 2018
@cmonr cmonr removed the rollup PR label Nov 26, 2018
@jarvte jarvte deleted the fix_bc95_todo branch December 3, 2018 06:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants