BLE: Fix iteration on connections in CordioGattServer. #8884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@lrusinowicz Let me know if the fix suits you. |
paul-szczepanek-arm
approved these changes
Nov 27, 2018
0xc0170
approved these changes
Nov 28, 2018
lrusinowicz
reviewed
Nov 29, 2018
| uint16_t conn_found = 0; | ||
|
|
||
| while ((conn_found < DM_CONN_MAX) && (conn_id < CONNECTION_ID_LIMIT)) { | ||
| for (dmConnId_t conn_id = DM_CONN_MAX; conn_id > DM_CONN_MAX; --conn_id) { |
There was a problem hiding this comment.
Shouldn't DM_CONN_ID_NONE be used in comparison here?
There was a problem hiding this comment.
yes, thanks for the fix @paul-szczepanek-arm
|
CI started |
Test run: SUCCESSSummary: 4 of 4 test jobs passed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #8880
Pull request type