Fix ESP8266 "Link Type" errors after reset #9130
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As part of the ESP8266 connect sequence, ESP8266Interface::connect, a software reset is performed. If the ESP8266 had been connected previously then the ESP8266 will sometimes send a "WIFI DISCONNECT" OOB message before performing the software reset. This causes the ESP8266::_oob_connection_status to change its state (_conn_status) from NSAPI_STATUS_DISCONNECTED to NSAPI_STATUS_CONNECTING. This causes ESP8266Interface::_startup, called later in the boot seqeunce, to skip ESP8266::startup. Without this call socket mux mode (CIPMUX=1) is never enabled and all send commands using this format fail with a "Link Type" error. This patch fixes that problem by unconditionally calling ESP8266::startup as part of the ESP8266 connect sequence.
|
Thanks for investigating and creating this fix with me @dlfryar |
|
Waiting on #9131 for a fix to Travis CI. |
VeijoPesonen
approved these changes
Dec 18, 2018
|
@adbridge - please get to next patch release. |
@ARMmbed/mbed-os-maintainers for better visibility |
0xc0170
approved these changes
Dec 18, 2018
SeppoTakalo
approved these changes
Dec 18, 2018
|
CI started |
Test run: FAILEDSummary: 1 of 11 test jobs failed Failed test jobs:
|
|
Restarted CI job: The job appears to not have connected to a device. Failure appears unrelated to PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As part of the ESP8266 connect sequence,
ESP8266Interface::connect, a software reset is performed. If the ESP8266 had been connected previously then the ESP8266 will sometimes send a "WIFI DISCONNECT" OOB message before performing the software reset. This causes the functionESP8266::_oob_connection_statusto get called and change its state (_conn_status) from NSAPI_STATUS_DISCONNECTED to NSAPI_STATUS_CONNECTING. This causesESP8266Interface::_startup, called later in the boot seqeunce, to skipESP8266::startup. Without this call socket mux mode (CIPMUX=1) is never enabled and all send commands using this format fail with a "Link Type" error.This patch fixes that problem by unconditionally calling
ESP8266::startupas part of the ESP8266 connect sequence.Pull request type