Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add versioning limits to intervaltree module #9131

Merged
merged 1 commit into from
Dec 17, 2018

Conversation

cmonr
Copy link
Contributor

@cmonr cmonr commented Dec 17, 2018

Description

PyOCD (required by mbed-host-test) does not do version capping in it's setup.py module requirements, which is pulling a breaking change/latest major release of intervaltree, (3.0.0 was released today). As a result, Travis CI builds are breaking.

This PR caps the module version before checking PyOCD.

Proof that issue is fixed: https://travis-ci.org/cmonr/mbed-os/builds/469097405

Pull request type

[x] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

@rik
Copy link

rik commented Dec 17, 2018

For this kind of second level dependency pinning, I'd recommend using constraints files to keep separate the packages you rely on and the packages they in turn rely on.

@cmonr
Copy link
Contributor Author

cmonr commented Dec 17, 2018

Thanks @rik ! Will definitely be checking that out.

@cmonr
Copy link
Contributor Author

cmonr commented Dec 17, 2018

CI started

@mbed-ci
Copy link

mbed-ci commented Dec 17, 2018

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 42f01f3 into ARMmbed:master Dec 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants