Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable MPU support on NRF52x platforms #9182

Merged
merged 1 commit into from
Jan 3, 2019

Conversation

donatieng
Copy link
Contributor

@donatieng donatieng commented Dec 21, 2018

Description

This PR disables MPU support on NRF52x devices. Unfortunately, the Nordic Softdevice seems to attempt writes to addresses marked as "Write only" under certain conditions. For instance, this behaviour is triggered when attempting to discover GATT services on a remote peripheral, while in central mode.
Thanks to @pan- for the investigation.

MPU support can still be enabled if using Cordio, or if the Bluetooth feature is disabled.

This workaround creates an issue (MPU support disabled on NRF52x devices) - opening the following ticket to track it till the root cause is fixed and we can re-enable MPU on these platforms: #9181

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-hal

@donatieng donatieng requested a review from a team December 21, 2018 12:23
Copy link
Member

@bulislaw bulislaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should track, investigate and possibly fix all of the platforms with disabled MPU. Do we need a ticket per board?

@cmonr
Copy link
Contributor

cmonr commented Dec 27, 2018

CI started.
An answer to @bulislaw's question should still be provided.

Personal opinion: One constantly updated tracking issue should be sufficient.

@mbed-ci
Copy link

mbed-ci commented Dec 27, 2018

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

@cmonr
Copy link
Contributor

cmonr commented Dec 28, 2018

Personal opinion: One constantly updated tracking issue should be sufficient.

Counter argument: Seperate tickets/isuses may make tracking easier.

Copy link
Member

@pan- pan- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting the PR; the cause of the issue was a bit surprising to say the least.

@cmonr
Copy link
Contributor

cmonr commented Jan 2, 2019

Will merge once at least one linked issue is posted here for tracking purposes cough @bulislaw @donatieng @c1728p9 cough

@donatieng
Copy link
Contributor Author

donatieng commented Jan 3, 2019

cough the issue has been here all along cough (PR description)
#9181
😉

@kjbracey
Copy link
Contributor

kjbracey commented Jan 3, 2019

cough the issue has been here all along cough (PR description)

I think the confusion is arising because there's no "fixes" issue indicated, so people are assuming that #9181 is what this is fixing...

@donatieng
Copy link
Contributor Author

donatieng commented Jan 3, 2019

Unfortunately we cannot fix the underlying bug as is it present in the Nordic Softdevice; that being said applications not using the Softdevice (including Cordio Link Layer) are unaffected

@donatieng
Copy link
Contributor Author

Good point @kjbracey-arm, I'll clarify this in the PR's description

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 3, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 3, 2019

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

@cmonr cmonr merged commit 757626a into ARMmbed:master Jan 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants