-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable MPU support on NRF52x platforms #9182
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should track, investigate and possibly fix all of the platforms with disabled MPU. Do we need a ticket per board?
CI started. Personal opinion: One constantly updated tracking issue should be sufficient. |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Counter argument: Seperate tickets/isuses may make tracking easier. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for submitting the PR; the cause of the issue was a bit surprising to say the least.
Will merge once at least one linked issue is posted here for tracking purposes cough @bulislaw @donatieng @c1728p9 cough |
cough the issue has been here all along cough (PR description) |
I think the confusion is arising because there's no "fixes" issue indicated, so people are assuming that #9181 is what this is fixing... |
Unfortunately we cannot fix the underlying bug as is it present in the Nordic Softdevice; that being said applications not using the Softdevice (including Cordio Link Layer) are unaffected |
Good point @kjbracey-arm, I'll clarify this in the PR's description |
CI started |
Test run: SUCCESSSummary: 11 of 11 test jobs passed |
Description
This PR disables MPU support on NRF52x devices. Unfortunately, the Nordic Softdevice seems to attempt writes to addresses marked as "Write only" under certain conditions. For instance, this behaviour is triggered when attempting to discover GATT services on a remote peripheral, while in central mode.
Thanks to @pan- for the investigation.
MPU support can still be enabled if using Cordio, or if the Bluetooth feature is disabled.
This workaround creates an issue (MPU support disabled on NRF52x devices) - opening the following ticket to track it till the root cause is fixed and we can re-enable MPU on these platforms: #9181
Pull request type
Reviewers
@ARMmbed/mbed-os-hal