Adds an NFC System Test suite #9184
Conversation
|
Please review Travis astyle job, there are failures. I assume once reviewers are done, this will be rebased (history needs clean up - some merges can be eliminated as well) |
|
@ConradBraam, thank you for your changes. |
|
@ConradBraam Looks like the review-bot found an interesting issue with the PR. This PR has a merge commit from ARMmbed/master in it, which confused the bot. Please remove the commit, and instead rebase your master branch to update this PR. |
|
@ConradBraam Taking a closer look at this commit, it looks like multiple merges from ARMmbed/master into this PR branch occurred, which will make the resolution much more difficult. I would suggest taking a look at interactive rebasing the branch ( @geky @kjbracey-arm Y'all konw a bit more git-fu than I do. Any suggestions? |
| @@ -0,0 +1,284 @@ | |||
| /* mbed Microcontroller Library | |||
There was a problem hiding this comment.
smart poster class is only for testing? shouldn't it be available for normal usage?
There was a problem hiding this comment.
That would be useful to have a Smart Poster class in the codebase however we should do design review of the example one and see if it can fit the mbed os codebase.
TEST_APPS/device/nfcapp/main.cpp
Outdated
| using mbed::nfc::ndef::common::span_from_cstr; | ||
|
|
||
|
|
||
| //void cmd_ready_cb(int retcode) |
TEST_APPS/device/nfcapp/main.cpp
Outdated
| } | ||
|
|
||
| const char *errorcodes = // descriptions from nfc/stack/nfc_errors.h | ||
| " 0 NFC_OK \n" |
There was a problem hiding this comment.
does \n without \r work as a newline?
| #include "nfcprocess.h" | ||
| #include "nfccommands.h" | ||
|
|
||
| events::EventQueue nfcQueue; |
There was a problem hiding this comment.
are these meant to be global?
you also mix naming convetions, camel, snake (and hungarian notation?)
There was a problem hiding this comment.
| #if MBED_CONF_NFCEEPROM | ||
| mbed::nfc::NFCEEPROMDriver& eeprom_driver = get_eeprom_driver(nfcQueue); | ||
|
|
||
| return ( (NFCTestShim *)(new NFCProcessEEPROM(nfcQueue, eeprom_driver)) ); |
There was a problem hiding this comment.
it's OK, you don't need to cast
| } | ||
|
|
||
| int HandleTestCommand::cmd_read_message(int argc, char *argv[]) { | ||
| nfcQueue.call(pNFC_Test_Shim, &NFCTestShim::on_read_nfceeprom); |
There was a problem hiding this comment.
the "on_" prefix is confusing as this isn't an event triggered by reading
There was a problem hiding this comment.
changed this to follow the cmd_ prefix which makes the invoke source clearer and is consistent
| return(CMDLINE_RETCODE_INVALID_PARAMETERS); | ||
| } else { | ||
| // parse arg and queue it up | ||
| char * uri = (char*)malloc(MAX_URL_LENGTH+1); |
There was a problem hiding this comment.
you can malloc and copy the correct length
There was a problem hiding this comment.
Good spot, cleaner to copy just the string.
|
|
||
| // todo: jira IOTPAN-295 | ||
| int HandleTestCommand::cmd_erase(int argc, char *argv[]){ | ||
| nfcQueue.call(pNFC_Test_Shim, &NFCTestShim::on_erase); |
There was a problem hiding this comment.
same problem with on_ prefix (unless I misunderstood the flow?)
There was a problem hiding this comment.
cmd_ prefixed now
|
@cmonr Git magic applied. |
|
@0xc0170 Anything still left to cover? |
|
This test addition deserves release notes addition ! please add it to the first comment above (following ARMmbed/mbed-os-5-docs#933) |
|
starting CI |
Test run: SUCCESSSummary: 9 of 9 test jobs passed |
|
@AnotherButler Can you please review Readme addition here? Waiting for the last review from docs, and this will be ready for integration |
Description
A icetea test framework based test suite, requires a card reader attached to the host and a target which is NFC capable using one of the supported drivers+shield.
see: readme file /TEST_APPS/testcases/nfc/README.MD includes notes to make test work with customer supplied NFC drivers, and memory limitations. Test suite only supports Type4 tag emulation EEPROM/Controller chips.
Pull request type
Reviewers
Release Notes
Adds an automated test suite which provides Standalone and End-2-End validation for either the supported PN512 NFC Controller shield or the M24SR NFC EEPROM. This is an icetea framework based test suite and requires additional hardware.